Re: [PATCHES] GIN improvements

Jeff Davis <pgsql@j-davis.com>

From: Jeff Davis <pgsql@j-davis.com>
To: Teodor Sigaev <teodor@sigaev.ru>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, Tom Lane <tgl@sss.pgh.pa.us>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2009-01-20T18:01:29Z
Lists: pgsql-hackers
On Mon, 2009-01-19 at 19:53 +0300, Teodor Sigaev wrote:
> I see only two guaranteed solution of the problem:
> - after limit is reached, force normal index inserts. One of the motivation of 
> patch was frequent question from users: why update of whole table with GIN index 
> is so slow? So this way will not resolve this question.
> - after limit is reached, force cleanup of pending list by calling 
> gininsertcleanup. Not very good, because users sometimes will see a huge 
> execution time of simple insert. Although users who runs a huge update should be 
> satisfied.
> 
> I have difficulties in a choice of way. Seems to me, the better will be second 
> way: if user gets very long time of insertion then (auto)vacuum of his 
> installation should tweaked.
> 

I agree that the second solution sounds better to me.

With the new Visibility Map, it's more reasonable to run VACUUM more
often, so those that are inserting single tuples at a time should not
encounter the long insert time.

I'm still looking at the rest of the patch.

Regards,
	Jeff Davis