Horton

Re: Preventing abort() and exit() calls in libpq

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Michael Paquier <michael@paquier.xyz>, Jacob Champion <pchampion@vmware.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, info@cspug.cz
Date: 2021-07-03T14:10:13Z
Lists: pgsql-hackers 
Noah Misch <noah@leadboat.com> writes:
> On Fri, Jul 02, 2021 at 11:20:17AM -0400, Tom Lane wrote:
>> Ugh.  What in the world is producing those references?

> Those come from a statically-linked libldap_r:

Blech!  I wonder if there is some way to avoid counting that.
It's not really hard to imagine that such a library might
contain an exit() call, for example, thus negating our test
altogether.

I'm now wondering about applying the test to *.o in libpq,
as well as libpgport_shlib.a and libpgcommon_shlib.a.
The latter would require some code changes, and it would make
the prohibition extend further than libpq alone.  On the bright
side, we could reinstate the check for abort().

			regards, tom lane

Commits

  1. Further restrict the scope of no-exit()-in-libpq test.

  2. Improve build-time check that libpq doesn't call exit().

  3. Fix portability fallout from commit dc227eb82.

  4. Add a build-time check that libpq doesn't call exit() or abort().