Horton

Re: Detection of hadware feature => please do not use signal

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Bastien Roucariès <rouca@debian.org>, pgsql-bugs@lists.postgresql.org
Date: 2024-11-25T01:27:13Z
Lists: pgsql-bugs 
Thomas Munro <thomas.munro@gmail.com> writes:
> It does work on the "armv7" target BF animals, though.  I assume they
> don't get any updates as they're all old/defunct distros (one of my
> favourite features of our boneyard^Wbuildfarm), but one of them is GCC
> "10.2.1 20210110", which is what made me suspicious of that -mfpu
> stuff, beyond my comprehension without a lot more coffee, that got
> backpatched in late 2021.

Ah, you're looking at mereswine, which is hard-float according to

checking build system type... armv7l-unknown-linux-gnueabihf
checking host system type... armv7l-unknown-linux-gnueabihf

I also confirmed that our existing code works on Fedora 30 armv7l
(also hard-float) with gcc 9.3.1.  That's the only other ARM32
image I have at hand :-(

So yeah, it would seem they broke it between 10.2.1 and 10.5.0.

			regards, tom lane

Commits

  1. Update configure probes for CFLAGS needed for ARM CRC instructions.

  2. Support runtime CRC feature probing on NetBSD/ARM using sysctl().

  3. Use auxv to check for CRC32 instructions on ARM.

  4. Improve our method for probing the availability of ARM CRC instructions.