Re: pgsql: Add support for hyperbolic functions, as well as log10().
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>, Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Lætitia Avrot <laetitia.avrot@gmail.com>
Date: 2019-03-14T02:44:30Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes: > On Wed, Mar 13, 2019 at 10:39 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> No, but that's not the hazard. I have a very fresh-in-mind example: >> at one point while tweaking Laetitia's patch, I'd accidentally changed >> datanh so that it called tanh not atanh. The previous set of tests did >> not reveal that :-( > Well, that was a goof, but it's not likely that such a regression will > ever be reintroduced. Sure, but how about this for another example: maybe a given platform hasn't got these functions (or they're in a different library we didn't pull in), but you don't see a failure until you actually call them. We try to set up our link options so that that sort of failure is reported at build time, but I wouldn't care to bet that we've succeeded at that everywhere. regards, tom lane
Commits
-
Further adjust the tests for the hyperbolic functions.
- c43ecdee0fff 12.0 landed
-
Adjust the tests for the hyperbolic functions.
- c015f853bf59 12.0 landed
-
Rethink how to test the hyperbolic functions.
- c6f153dcfebc 12.0 landed
-
Add support for hyperbolic functions, as well as log10().
- f1d85aa98ee7 12.0 cited