Re: CI: Add task that runs pgindent
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Jelte Fennema-Nio <me@jeltef.nl>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
Florents Tselai <florents.tselai@gmail.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
Nazir Bilal Yavuz <byavuz81@gmail.com>
Date: 2025-10-23T14:27:11Z
Lists: pgsql-hackers
> On 23 Oct 2025, at 11:40, Jelte Fennema-Nio <me@jeltef.nl> wrote: > > On Wed, 22 Oct 2025 at 14:06, Daniel Gustafsson <daniel@yesql.se> wrote: >> I like the different shape and symbol, but I would probably keep it green to >> indicate that it's informational rather than actionable. We don't want a >> flurry of patch re-submissions with only whitespace changes eating CI resources >> when the previous build was successful. Just my €0,02. > > I understand the concern. So I tried out making the icon green now > (see attached), but it looks a bit weird imo. Unless some others > prefer the green too (or have some other idea for an icon), I'm > inclined to keep it the yellow/orange color it is now. If we actually > do get a bunch of useless re-submissions, we can consider changing it. If the set of icons grows from the self-explanatory red/green we should perhaps document what the diffent colors mean in the help page? -- Daniel Gustafsson