Re: [PATCH] Free memory allocated by waitonlock_error_callback()

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Michael Paquier <michael@paquier.xyz>

Cc: Quan Zongliang <quanzongliang@yeah.net>, Aleksander Alekseev <aleksander@tigerdata.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-10-23T04:29:35Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Provide error context when an error is thrown within WaitOnLock().
- f727b63e8107 19 (unreleased) cited

Michael Paquier <michael@paquier.xyz> writes:
> On Thu, Oct 23, 2025 at 11:18:09AM +0800, Quan Zongliang wrote:
>> Improve the completeness of the code.

> errfinish() calls MemoryContextReset() on ErrorContext so as any leaks
> like the one you are cleaning up are taken care of.  Still, what you
> are suggesting is simple enough and silences a bit valgrind, so agreed
> about the addition of this pfree().

> Let's see if somebody objects to that.

Yeah, I object.  Didn't 89d57c1fb already solve this in a more
general way?  If it's not fixed by that, why not?

			regards, tom lane