Horton

Re: [EXTERNAL] Re: [PATCH] Report the query string that caused a memory error under Valgrind

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Onur Tirtir <Onur.Tirtir@microsoft.com>
Cc: "peter.eisentraut@enterprisedb.com" <peter.eisentraut@enterprisedb.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2023-04-03T14:19:49Z
Lists: pgsql-hackers 
Onur Tirtir <Onur.Tirtir@microsoft.com> writes:
> Thank you for sharing your proposal as a patch. It looks much nicer and useful than mine.
> I've also tested it for a few cases --by injecting a memory error on purpose-- and seen that it helps reporting the problematic query.
> Should we move forward with v3 then?

OK, I pushed v3 as-is.  We can refine it later if anyone has suggestions.

Thanks for the contribution!

			regards, tom lane

Commits

  1. When using valgrind, log the current query after an error is detected.