Horton

Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files

Daniel Gustafsson <daniel@yesql.se>

View thread
From: Daniel Gustafsson <daniel@yesql.se>
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Tobias Bussmann <t.bussmann@gmx.net>, Tom Lane <tgl@sss.pgh.pa.us>, Mark Guertin <markguertin@gmail.com>, pgsql-bugs@lists.postgresql.org
Date: 2023-04-29T20:35:52Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Skip .DS_Store files in server side utils

> On 29 Apr 2023, at 01:42, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Fri, Apr 28, 2023 at 02:11:00PM +0200, Daniel Gustafsson wrote:
>> Thanks!  I've parked it in the July commitfest to keep it from being forgotten
>> about when the tree re-opens.
> 
> I'm OK to hold on this patch until v17 opens for business, but isn't
> that something we'd better backpatch at some point?  The behavior of
> the stable branches is kind of annoying, in my opinion.

My thinking is that skipping non-postgres files which really have no business
being there in the first place is a new feature and not a bugfix, but I can see
merit in your argument too.  If the RMT and -hackers have other opinions then
I'm not going to object.

--
Daniel Gustafsson