Horton

Re: Add PGDLLIMPORT lines to some variables

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Craig Ringer <craig@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Peter Geoghegan <pg@bowt.ie>, Noah Misch <noah@leadboat.com>, Andres Freund <andres@anarazel.de>, Brian Cloutier <brian@citusdata.com>, Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2019-06-13T14:56:06Z
Lists: pgsql-hackers 
[ blast-from-the-past department ]

Craig Ringer <craig@2ndquadrant.com> writes:
> On 5 December 2017 at 22:49, Robert Haas <robertmhaas@gmail.com> wrote:
>>     Mark assorted variables PGDLLIMPORT.

> I was going to pipe up here to add ReplicationSlotCtl to the list.
> Otherwise the only way to access slot information is via the SPI and
> pg_stat_replication_slots, which isn't super fun. And it's not like
> ReplicationSlotCtl is any more internal than MyReplicationSlot.

> I missed the boat on your commit, but ... please?

Not sure why this request was ignored, but now that we have another
request for the same thing [1], I've pushed this.

			regards, tom lane

[1] https://postgr.es/m/345138875.20190611151943@cybertec.at

Commits

  1. Mark ReplicationSlotCtl as PGDLLIMPORT.

  2. Mark assorted variables PGDLLIMPORT.

  3. contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.