Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove pgbench "progress" test pending solution of its timing is (fwd)
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>,
Heikki Linnakangas <hlinnaka@iki.fi>,
PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-02-18T00:06:09Z
Lists: pgsql-hackers
Fabien COELHO <coelho@cri.ensmp.fr> writes: >> Unfortunately, there was no activity over the last few commitfests and the >> proposed patch pgbench-tap-progress-6 can't be applied anymore without >> conflicts. Fabien, what are your plans about it, could you please post a >> rebased version? > Here it is. I'm confused about the intended scope of this patch. The thread title refers only to adding a regression test, but the actual patch includes nontrivial C-code changes, and a skim of the recent discussion suggests that there are some bug fixes involved. Please clarify. As I think I made clear already, I am not in favor of adding more timing-sensitive regression tests here. I do not think there is value commensurate with the risk of intermittent test failures. However, if we're fixing bugs or poor behavior, that's certainly worth doing. regards, tom lane
Commits
-
Refactor code to print pgbench progress reports.
- 9f75e3772350 12.0 landed
-
Fix pgbench TAP test to work in VPATH builds.
- e94f2bc809a0 11.0 cited