Horton

Re: Getting rid of "unknown error" in dblink and postgres_fdw

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Joe Conway <mail@joeconway.com>
Cc: pgsql-hackers@postgresql.org
Date: 2016-12-22T05:20:30Z
Lists: pgsql-hackers 
Joe Conway <mail@joeconway.com> writes:
> On 12/21/2016 04:22 PM, Tom Lane wrote:
>> In short, yes, please copy that bit into dblink.

> The attached should do the trick I think.

I see that you need to pass the PGconn into dblink_res_error() now, but
what's the point of the new "bool fail" parameter?

> You think it is reasonable to backpatch this part too?

Yes, definitely.

			regards, tom lane

Commits

  1. Make dblink try harder to form useful error messages

  2. Improve dblink error message when remote does not provide it