Horton

Re: Convert planner's AggInfo and AggTransInfo to Nodes

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2022-07-19T16:31:08Z
Lists: pgsql-hackers 
=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org> writes:
> It seems like a reasonable idea, but I don't know enough to judge the
> wider ramifications of it.  But one thing that the patch should also do,
> is switch to using the l*_node() functions instead of manual casting.

Hm, I didn't bother with that on the grounds that there's no question
what should be in those two lists.  But I guess it's not much extra
code, so pushed that way.

			regards, tom lane

Commits

  1. Dump more fields when dumping planner internal data structures.

  2. Make serialization of Nodes' scalar-array fields more robust.

  3. Convert planner's AggInfo and AggTransInfo structs to proper Nodes.