Horton

Re: The pgperltidy diffs in HEAD

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Álvaro Herrera <alvherre@kurilemu.de>, Pgsql Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-25T17:35:52Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Check for correct version of perltidy

Daniel Gustafsson <daniel@yesql.se> writes:
> On 25 Nov 2025, at 17:00, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
>>> Hmm, I wonder if you ran this with our documented version of perltidy.

> ..and since I managed to run it with the wrong version for the attached diff that
> argument certainly does have merit (I now gave up on having two version
> installed for $reasons and will settle on the postgres-mandated version for all
> things).

pgindent has long had a check that you're running the correct version
of bsdindent, but I just realized that pgperltidy makes no such check
for perltidy.  Should we install one?

			regards, tom lane