Re: VacAttrStatsP vs VacAttrStats * (typedef'ing pointer types)
Neil Conway <neilc@samurai.com>
From: Neil Conway <neilc@samurai.com>
To: Jan Urbański <j.urbanski@students.mimuw.edu.pl>
Cc: Postgres - Hackers <pgsql-hackers@postgresql.org>
Date: 2008-05-02T21:53:01Z
Lists: pgsql-hackers
On Fri, 2008-05-02 at 23:22 +0200, Jan Urbański wrote: > While looking around vacuum.h (for my GSoC project) I found: > typedef struct VacAttrStats *VacAttrStatsP; > and then throughout the code sometimes VacAttrStats *foo is used and > sometimes VacAttrStatsP bar is used. Personally I think we should be consistent about this and just use one form for a given type. (I don't really care which variant is preferred. Personally, I think that hiding pointer types inside a typedef is evil and wrong, but it is relatively common practice in the source...) -Neil