Horton

Re: Possible regression setting GUCs on \connect

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: David Steele <david@pgmasters.net>, Alexander Korotkov <akorotkov@postgresql.org>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2023-04-27T19:34:55Z
Lists: pgsql-hackers 
Nathan Bossart <nathandbossart@gmail.com> writes:
> I suspect the problem is that GUCArrayDelete() is using the wrong Datum:

> -                newUsersetArray = construct_array_builtin(&d, 1, BOOLOID);
> +                newUsersetArray = construct_array_builtin(&userSetDatum, 1, BOOLOID);

Ah, should have checked my mail earlier.

However, my concern about whether we even want this feature
still stands.

			regards, tom lane

Commits

  1. Revert "Add USER SET parameter values for pg_db_role_setting"

  2. Fix wrong construct_array_builtin() call in GUCArrayDelete()

  3. In hstore_plpython, avoid crashing when return value isn't a mapping.

  4. Allow granting SET and ALTER SYSTEM privileges on GUC parameters.