Horton

Re: Alpha4 release blockers (was Re: wrapping up this CommitFest)

Peter Eisentraut <peter_e@gmx.net>

View thread
From: Peter Eisentraut <peter_e@gmx.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org, Rémi Zara <remi_zara@mac.com>, Stefan Huehner <stefan@huehner.org>
Date: 2011-03-08T22:25:08Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Further refine patch for commenting operator implementation functions.

  2. Fix citext's upgrade-from-unpackaged script to set its collation correctly.

  3. Mark operator implementation functions as such in their comments.

  4. Add KNNGIST support to contrib/btree_gist.

  5. Fix plpython breakage detected on certain Fedora machines on buildfarm.

On mån, 2011-03-07 at 12:40 -0500, Tom Lane wrote:
> Fair enough, but throwing in fmgr_info_collation(DEFAULT_COLLATION)
> anytime we have a problem seems to me to introduce the exact same
> issue.  Who's to say that that's really the appropriate value to use?

It normally isn't the appropriate value to use.  It's only appropriate
if either that particular part of the code doesn't support collations
yet or it's dealing with some hardcoded catalog lookups or some similar
case.  In most other cases you should be getting the collation passed in
from somewhere, and if you aren't there is probably some work to do to
get it there.  That's at least sort of the experience from developing
this.