Horton

Re: pg_upgrade fails to detect unsupported arrays and ranges

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Tomas Vondra <tomas.vondra@2ndquadrant.com>
Date: 2019-11-10T23:06:17Z
Lists: pgsql-hackers 
Daniel Gustafsson <daniel@yesql.se> writes:
> Applies, builds clean and passes light testing.

Thanks for checking!

> I can see the appeal of
> including it before the wrap, even though I personally would've held off.

Nah, I'm not gonna risk it at this stage.  I concur with your point
that this is an ancient bug, and one that is unlikely to bite many
people.  I'll push it Wednesday or so.

			regards, tom lane

Commits

  1. Improve wording of some pg_upgrade failure reports.

  2. Fix some more omissions in pg_upgrade's tests for non-upgradable types.

  3. Handle arrays and ranges in pg_upgrade's test for non-upgradable types.