Re: Review: Fix snapshot taking inconsistencies
Alvaro Herrera <alvherre@commandprompt.com>
From: Alvaro Herrera <alvherre@commandprompt.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi>, Steve Singer <ssinger_pg@sympatico.ca>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2011-02-24T00:35:13Z
Lists: pgsql-hackers
Excerpts from Tom Lane's message of mié feb 23 19:39:23 -0300 2011: > Alvaro Herrera <alvherre@commandprompt.com> writes: > > Excerpts from Marko Tiikkaja's message of sáb ene 15 17:30:14 -0300 2011: > >> On 2010-10-21 3:32 PM +0200, Marko Tiikkaja wrote: > > <patch> > >> > >> Here's the patch rebased against the master. No code changes since the > >> last patch I sent. > > > Having a look at this. > > My recollection is that this was pretty tightly coupled to the wCTE > patch. I had been intending to review them together, and have just > now come up for air enough to start doing that. Do you really want > to review this one separately? Dunno. If you're gonna pick it up I guess my time is best spent elsewhere. There was some restructuring in code in postgres.c to be done near this patch, which wasn't attacked at all by Marko AFAICS. Maybe I should be looking at that instead. -- Álvaro Herrera <alvherre@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support