Re: Review: Fix snapshot taking inconsistencies
Alvaro Herrera <alvherre@commandprompt.com>
From: Alvaro Herrera <alvherre@commandprompt.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi>, Steve Singer <ssinger_pg@sympatico.ca>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2011-02-24T15:06:17Z
Lists: pgsql-hackers
Excerpts from Alvaro Herrera's message of mié feb 23 21:35:13 -0300 2011: > Excerpts from Tom Lane's message of mié feb 23 19:39:23 -0300 2011: > > My recollection is that this was pretty tightly coupled to the wCTE > > patch. I had been intending to review them together, and have just > > now come up for air enough to start doing that. Do you really want > > to review this one separately? > > Dunno. If you're gonna pick it up I guess my time is best spent > elsewhere. There was some restructuring in code in postgres.c to be > done near this patch, which wasn't attacked at all by Marko AFAICS. > Maybe I should be looking at that instead. ... but then, if I did that, I could create merge conflicts for you, so please have at it. I think pure beautification code cleanups can way till 9.2 starts. -- Álvaro Herrera <alvherre@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support