Thread
-
Time for 7.2.1?
Tom Lane <tgl@sss.pgh.pa.us> — 2002-03-08T01:28:09Z
Seems like it's about time to release 7.2.1. We have enough post-release patches in there that a dot-release is clearly needed (particularly for the pg_dump-related issues). And it seems like not too much new stuff is coming in. Does anyone have any issues outstanding that need to be dealt with before 7.2.1? regards, tom lane Post-release patches in the 7.2 branch: 2002-03-05 01:10 momjian * contrib/tsearch/dict/porter_english.dct (REL7_2_STABLE): Please, apply attached patch for contrib/tsearch to 7.2.1 and current CVS. It fix english stemmer's problem with ending words like 'technology'. We have found one more bug in english stemmer. The bug is with 'irregular' english words like 'skies' -> 'sky'. Please, apply attached cumulative patch to 7.2.1 and current CVS instead previous one. Thank to Thomas T. Thai <tom@minnesota.com> for hard testing. This kind of bug has significance only for dump/reload database and viewing, but searching/indexing works right. Teodor Sigaev 2002-03-05 00:13 tgl * src/backend/optimizer/prep/prepunion.c (REL7_2_STABLE): Previous patch to mark UNION outputs with common typmod (if any) breaks three-or-more-way UNIONs, as per example from Josh Berkus. Cause is a fragile assumption that one tlist's entries will exactly match another. Restructure code to make that assumption a little less fragile. 2002-03-04 22:45 ishii * src/: backend/utils/adt/timestamp.c, test/regress/expected/timestamp.out, test/regress/expected/timestamptz.out (REL7_2_STABLE): A backport patch: Fix bug in extract/date_part for milliseconds/miscroseconds and timestamp/timestamptz combo. Now extract/date_part returns seconds*1000 or 1000000 + fraction part as the manual stats. regression test are also fixed. See the thread in pgsql-hackers: Subject: Re: [HACKERS] timestamp_part() bug? Date: Sat, 02 Mar 2002 11:29:53 +0900 2002-03-04 12:47 tgl * doc/FAQ_Solaris (REL7_2_STABLE): Update FAQ_Solaris with info about gcc 2.95.1 problems and how to work around 64-bit vsnprintf bug. 2002-02-27 18:17 tgl * src/backend/tcop/postgres.c (REL7_2_STABLE): Back-patch fix for errors reported at transaction end. 2002-02-26 20:47 ishii * src/backend/commands/copy.c (REL7_2_STABLE): Back-patch fix for followings: Fix bug in COPY FROM when DELIMITER is not in ASCII range. See pgsql-bugs/pgsql-hackers discussion "COPY FROM is not 8bit clean" around 2002/02/26 for more details -- Tatsuo Ishii 2002-02-26 18:48 tgl * src/: backend/commands/command.c, backend/commands/explain.c, backend/executor/functions.c, backend/executor/spi.c, backend/nodes/copyfuncs.c, backend/nodes/equalfuncs.c, backend/nodes/readfuncs.c, backend/parser/analyze.c, backend/tcop/dest.c, backend/tcop/postgres.c, backend/tcop/pquery.c, backend/tcop/utility.c, include/commands/command.h, include/nodes/parsenodes.h, include/tcop/dest.h, include/tcop/pquery.h, include/tcop/utility.h (REL7_2_STABLE): Back-patch fix for command completion report handling. This is primarily needed so that INSERTing a row still reports the row's OID even when there are ON INSERT rules firing additional queries. 2002-02-25 16:37 tgl * src/bin/psql/command.c (REL7_2_STABLE): Tweak psql's \connect command to not downcase unquoted database and user names. This is a temporary measure to allow backwards compatibility with 7.2 and earlier pg_dump. 7.2.1 and later pg_dump will double-quote mixed case names in \connect. Once we feel that older dumps are not a problem anymore, we can revert this change and treat \connect arguments as normal SQL identifiers. 2002-02-25 15:07 momjian * src/backend/libpq/auth.c (REL7_2_STABLE): Fix for PAM error message display: > and that the right fix is to make each of the subsequent calls be in > this same pattern, not to try to emulate their nonsensical style. Dominic J. Eidson 2002-02-25 11:22 thomas * src/backend/utils/adt/datetime.c (REL7_2_STABLE): Add a large number of time zones to the lookup table. Fix a few apparently-wrong TZ vs DTZ declarations. Same patch as added to HEAD. 2002-02-22 10:40 momjian * src/include/libpq/pqsignal.h (REL7_2_STABLE): We had a problem with to compile pgsql-7.2 under SW-8.0. In the mailing lists I found no informations. See note for further informations. Add missing AuthBlockSig. regards Heiko 2002-02-22 08:02 momjian * doc/: FAQ_russian, src/FAQ/FAQ_russian.html (REL7_2_STABLE): BACKPATCH: Add Russian FAQ to 7.2.1. Why not? 2002-02-22 01:08 momjian * contrib/btree_gist/btree_gist.c (REL7_2_STABLE): BACKPATCH: Please, apply attached patch of contrib/btree_gist to 7.2.1 and current cvs. The patch fixes memory leak during creation GiST index on timestamp column. Thank you. -- Teodor Sigaev teodor@stack.net 2002-02-19 17:19 tgl * src/backend/utils/adt/cash.c (REL7_2_STABLE): Avoid failures in cash_out and cash_words for INT_MIN. Also, 'fourty' -> 'forty'. 2002-02-18 11:04 tgl * src/backend/commands/analyze.c (REL7_2_STABLE): Replace number-of-distinct-values estimator equation, per recent pghackers discussion. 2002-02-17 23:12 ishii * src/bin/pgaccess/lib/tables.tcl (REL7_2_STABLE): Fix kanji-coversion key binding. This has been broken since 7.1 Per Yoshinori Ariie's report. 2002-02-17 08:29 momjian * doc/src/sgml/ref/alter_table.sgml: Fix SGML typo in previous patch. 2002-02-17 06:50 momjian * doc/src/sgml/ref/alter_table.sgml: I think it's important that it's actually documented that they can add primary keys after the fact! Also, we need to add regression tests for alter table / add primary key and alter table / drop constraint. These shouldn't be added until 7.3 tho methinks... Chris 2002-02-16 18:45 momjian * doc/src/sgml/ref/alter_table.sgml: Clarify params to ALTER TABLE to clearly show single parameters. e.g. table contraint definition -> table_constraint_definition. 2002-02-15 12:46 petere * src/interfaces/ecpg/preproc/pgc.l: Remove warning about automatic inclusion of sqlca. 2002-02-14 10:24 tgl * src/: backend/commands/command.c, backend/executor/spi.c, backend/utils/mmgr/portalmem.c, include/utils/portal.h: Ensure that a cursor is scanned under the same scanCommandId it was originally created with, so that the set of visible tuples does not change as a result of other activity. This essentially makes PG cursors INSENSITIVE per the SQL92 definition. See bug report of 13-Feb-02. 2002-02-13 14:32 tgl * doc/src/sgml/ref/createuser.sgml: Point out that --adduser actually makes the new user a superuser. This was mentioned on the man page for the underlying CREATE USER command, but it should be explained here too. 2002-02-12 18:39 tgl * src/backend/port/dynloader/: README.dlfcn.aix, aix.h, bsdi.h, dgux.h, freebsd.h, irix5.h, linux.h, netbsd.h, openbsd.h, osf.h, sco.h, solaris.h, sunos4.h, svr4.h, univel.h, unixware.h, win.h: Use RTLD_NOW, not RTLD_LAZY, as binding mode for dlopen() on all platforms. This restores the Linux behavior to what it was in PG 7.0 and 7.1, and causes other platforms to agree. (Other well-tested platforms like HPUX were doing it this way already.) Per pghackers discussion over the past month or so. 2002-02-12 17:35 tgl * doc/FAQ_Solaris: Add warning not to use /usr/ucb/cc on Solaris. 2002-02-12 17:25 momjian * doc/src/sgml/advanced.sgml: Fix tutorial for references problem, from rainer.tammer@spg.schulergroup.com 2002-02-12 16:25 tgl * doc/src/sgml/ref/copy.sgml, src/backend/commands/copy.c: Modify COPY TO to emit carriage returns and newlines as backslash escapes (backslash-r, backslash-n) for protection against newline-conversion munging. In future we will also tweak COPY FROM, but this part of the change should be backwards-compatible. Per pghackers discussion. Also, update COPY reference page to describe the backslash conversions more completely and accurately. 2002-02-11 18:25 momjian * doc/src/sgml/wal.sgml: Update wal files computation documentation. 2002-02-11 17:41 tgl * src/backend/access/gist/gist.c: Tweak GiST code to work correctly on machines where 8-byte alignment of pointers is required. Patch from Teodor Sigaev per pghackers discussion. It's an ugly kluge but avoids forcing initdb; we'll put a better fix into 7.3 or later. 2002-02-11 16:38 petere * src/backend/port/dynloader/freebsd.h: Fix for old FreeBSD versions that don't have RTLD_GLOBAL 2002-02-11 15:10 tgl * src/backend/executor/: nodeIndexscan.c, nodeTidscan.c: Repair problems with EvalPlanQual where target table is scanned as inner indexscan (ie, one with runtime keys). ExecIndexReScan must compute or recompute runtime keys even if we are rescanning in the EPQ case. TidScan seems to have comparable problems. Per bug noted by Barry Lind 11-Feb-02. 2002-02-11 10:19 momjian * contrib/pg_upgrade/pg_upgrade: Fix flag handling of pg_upgrade. 2002-02-10 19:18 tgl * src/bin/pg_dump/: common.c, pg_backup.h, pg_backup_archiver.c, pg_dump.c, pg_dump.h, pg_dumpall.sh: Be more wary about mixed-case database names and user names. Get the CREATE DATABASE command right in pg_dump -C case. 2002-02-10 19:14 tgl * doc/src/sgml/ref/: pg_dump.sgml, pg_restore.sgml: pg_dump and pg_restore man pages need to mention that one should restore into a virgin database, ie, one created from template0, if there are any site-local additions in template1. 2002-02-10 17:56 tgl * src/backend/storage/file/fd.c: Don't Assert() that fsync() and close() never fail; I have seen this crash on Solaris when over disk quota. Instead, report such failures via elog(DEBUG). 2002-02-08 11:30 momjian * src/backend/utils/init/findbe.c: Move sys/types.h to top, for hiroyuki hanai/ FreeBSD. 2002-02-08 09:47 momjian * contrib/mysql/my2pg.pl: Upgrade my2pg version 1.23. 2002-02-07 17:20 tgl * src/backend/postmaster/pgstat.c: pgstat's truncation of query string needs to be multibyte-aware. Patch from sugita@sra.co.jp. 2002-02-07 17:11 tgl * contrib/: intarray/_int.c, tsearch/README.tsearch, tsearch/gistidx.c, tsearch/tsearch.sql.in: Repair some problems in GIST-index contrib modules. Patch from Teodor Sigaev <teodor@stack.net>. 2002-02-06 19:27 inoue * src/backend/tcop/utility.c: Removed a check for REINDEX TABLE. 2002-02-06 15:29 petere * doc/Makefile: Fix for parallel make 2002-02-06 12:27 tgl * src/bin/pg_dump/: pg_backup_archiver.c, pg_dump.c: Fix failure to reconnect as sequence's owner before issuing setval().
-
Re: Time for 7.2.1?
Nicolas Bazin <nbazin@ingenico.com.au> — 2002-03-08T03:05:24Z
The ecpg Patch I send correct a bug in the pre-processor that it would be nice to have in this release. ----- Original Message ----- From: "Tom Lane" <tgl@sss.pgh.pa.us> To: <pgsql-hackers@postgreSQL.org> Sent: Friday, March 08, 2002 12:28 PM Subject: [HACKERS] Time for 7.2.1? > Seems like it's about time to release 7.2.1. We have enough > post-release patches in there that a dot-release is clearly needed > (particularly for the pg_dump-related issues). And it seems like > not too much new stuff is coming in. Does anyone have any issues > outstanding that need to be dealt with before 7.2.1? > > regards, tom lane > > > Post-release patches in the 7.2 branch: > > 2002-03-05 01:10 momjian > > * contrib/tsearch/dict/porter_english.dct (REL7_2_STABLE): Please, > apply attached patch for contrib/tsearch to 7.2.1 and current CVS. > It fix english stemmer's problem with ending words like > 'technology'. > > We have found one more bug in english stemmer. The bug is with > 'irregular' english words like 'skies' -> 'sky'. Please, apply > attached cumulative patch to 7.2.1 and current CVS instead > previous one. > > Thank to Thomas T. Thai <tom@minnesota.com> for hard testing. This > kind of bug has significance only for dump/reload database and > viewing, but searching/indexing works right. > > Teodor Sigaev > > 2002-03-05 00:13 tgl > > * src/backend/optimizer/prep/prepunion.c (REL7_2_STABLE): Previous > patch to mark UNION outputs with common typmod (if any) breaks > three-or-more-way UNIONs, as per example from Josh Berkus. Cause > is a fragile assumption that one tlist's entries will exactly match > another. Restructure code to make that assumption a little less > fragile. > > 2002-03-04 22:45 ishii > > * src/: backend/utils/adt/timestamp.c, > test/regress/expected/timestamp.out, > test/regress/expected/timestamptz.out (REL7_2_STABLE): A backport > patch: > > Fix bug in extract/date_part for milliseconds/miscroseconds and > timestamp/timestamptz combo. Now extract/date_part returns > seconds*1000 or 1000000 + fraction part as the manual stats. > regression test are also fixed. > > See the thread in pgsql-hackers: > > Subject: Re: [HACKERS] timestamp_part() bug? Date: Sat, 02 Mar 2002 > 11:29:53 +0900 > > 2002-03-04 12:47 tgl > > * doc/FAQ_Solaris (REL7_2_STABLE): Update FAQ_Solaris with info > about gcc 2.95.1 problems and how to work around 64-bit vsnprintf > bug. > > 2002-02-27 18:17 tgl > > * src/backend/tcop/postgres.c (REL7_2_STABLE): Back-patch fix for > errors reported at transaction end. > > 2002-02-26 20:47 ishii > > * src/backend/commands/copy.c (REL7_2_STABLE): Back-patch fix for > followings: > > Fix bug in COPY FROM when DELIMITER is not in ASCII range. See > pgsql-bugs/pgsql-hackers discussion "COPY FROM is not 8bit clean" > around 2002/02/26 for more details -- Tatsuo Ishii > > 2002-02-26 18:48 tgl > > * src/: backend/commands/command.c, backend/commands/explain.c, > backend/executor/functions.c, backend/executor/spi.c, > backend/nodes/copyfuncs.c, backend/nodes/equalfuncs.c, > backend/nodes/readfuncs.c, backend/parser/analyze.c, > backend/tcop/dest.c, backend/tcop/postgres.c, > backend/tcop/pquery.c, backend/tcop/utility.c, > include/commands/command.h, include/nodes/parsenodes.h, > include/tcop/dest.h, include/tcop/pquery.h, include/tcop/utility.h > (REL7_2_STABLE): Back-patch fix for command completion report > handling. This is primarily needed so that INSERTing a row still > reports the row's OID even when there are ON INSERT rules firing > additional queries. > > 2002-02-25 16:37 tgl > > * src/bin/psql/command.c (REL7_2_STABLE): Tweak psql's \connect > command to not downcase unquoted database and user names. This is > a temporary measure to allow backwards compatibility with 7.2 and > earlier pg_dump. 7.2.1 and later pg_dump will double-quote mixed > case names in \connect. Once we feel that older dumps are not a > problem anymore, we can revert this change and treat \connect > arguments as normal SQL identifiers. > > 2002-02-25 15:07 momjian > > * src/backend/libpq/auth.c (REL7_2_STABLE): Fix for PAM error > message display: > > > and that the right fix is to make each of the subsequent calls be > in > > this same pattern, not to try to emulate their nonsensical style. > > Dominic J. Eidson > > 2002-02-25 11:22 thomas > > * src/backend/utils/adt/datetime.c (REL7_2_STABLE): Add a large > number of time zones to the lookup table. Fix a few > apparently-wrong TZ vs DTZ declarations. Same patch as added to > HEAD. > > 2002-02-22 10:40 momjian > > * src/include/libpq/pqsignal.h (REL7_2_STABLE): We had a problem > with to compile pgsql-7.2 under SW-8.0. In the mailing lists I > found no informations. See note for further informations. > > Add missing AuthBlockSig. > > regards Heiko > > 2002-02-22 08:02 momjian > > * doc/: FAQ_russian, src/FAQ/FAQ_russian.html (REL7_2_STABLE): > BACKPATCH: > > Add Russian FAQ to 7.2.1. Why not? > > 2002-02-22 01:08 momjian > > * contrib/btree_gist/btree_gist.c (REL7_2_STABLE): BACKPATCH: > > Please, apply attached patch of contrib/btree_gist to 7.2.1 and > current cvs. The patch fixes memory leak during creation GiST > index on timestamp column. > > Thank you. > > -- Teodor Sigaev teodor@stack.net > > 2002-02-19 17:19 tgl > > * src/backend/utils/adt/cash.c (REL7_2_STABLE): Avoid failures in > cash_out and cash_words for INT_MIN. Also, 'fourty' -> 'forty'. > > 2002-02-18 11:04 tgl > > * src/backend/commands/analyze.c (REL7_2_STABLE): Replace > number-of-distinct-values estimator equation, per recent pghackers > discussion. > > 2002-02-17 23:12 ishii > > * src/bin/pgaccess/lib/tables.tcl (REL7_2_STABLE): Fix > kanji-coversion key binding. This has been broken since 7.1 Per > Yoshinori Ariie's report. > > 2002-02-17 08:29 momjian > > * doc/src/sgml/ref/alter_table.sgml: Fix SGML typo in previous > patch. > > 2002-02-17 06:50 momjian > > * doc/src/sgml/ref/alter_table.sgml: I think it's important that > it's actually documented that they can add primary keys after the > fact! > > Also, we need to add regression tests for alter table / add primary > key and alter table / drop constraint. These shouldn't be added > until 7.3 tho methinks... > > Chris > > 2002-02-16 18:45 momjian > > * doc/src/sgml/ref/alter_table.sgml: Clarify params to ALTER TABLE > to clearly show single parameters. > > e.g. table contraint definition -> table_constraint_definition. > > 2002-02-15 12:46 petere > > * src/interfaces/ecpg/preproc/pgc.l: Remove warning about automatic > inclusion of sqlca. > > 2002-02-14 10:24 tgl > > * src/: backend/commands/command.c, backend/executor/spi.c, > backend/utils/mmgr/portalmem.c, include/utils/portal.h: Ensure that > a cursor is scanned under the same scanCommandId it was originally > created with, so that the set of visible tuples does not change as > a result of other activity. This essentially makes PG cursors > INSENSITIVE per the SQL92 definition. See bug report of 13-Feb-02. > > 2002-02-13 14:32 tgl > > * doc/src/sgml/ref/createuser.sgml: Point out that --adduser > actually makes the new user a superuser. This was mentioned on the > man page for the underlying CREATE USER command, but it should be > explained here too. > > 2002-02-12 18:39 tgl > > * src/backend/port/dynloader/: README.dlfcn.aix, aix.h, bsdi.h, > dgux.h, freebsd.h, irix5.h, linux.h, netbsd.h, openbsd.h, osf.h, > sco.h, solaris.h, sunos4.h, svr4.h, univel.h, unixware.h, win.h: > Use RTLD_NOW, not RTLD_LAZY, as binding mode for dlopen() on all > platforms. This restores the Linux behavior to what it was in PG > 7.0 and 7.1, and causes other platforms to agree. (Other > well-tested platforms like HPUX were doing it this way already.) > Per pghackers discussion over the past month or so. > > 2002-02-12 17:35 tgl > > * doc/FAQ_Solaris: Add warning not to use /usr/ucb/cc on Solaris. > > 2002-02-12 17:25 momjian > > * doc/src/sgml/advanced.sgml: Fix tutorial for references problem, > from rainer.tammer@spg.schulergroup.com > > 2002-02-12 16:25 tgl > > * doc/src/sgml/ref/copy.sgml, src/backend/commands/copy.c: Modify > COPY TO to emit carriage returns and newlines as backslash escapes > (backslash-r, backslash-n) for protection against > newline-conversion munging. In future we will also tweak COPY > FROM, but this part of the change should be backwards-compatible. > Per pghackers discussion. Also, update COPY reference page to > describe the backslash conversions more completely and accurately. > > 2002-02-11 18:25 momjian > > * doc/src/sgml/wal.sgml: Update wal files computation > documentation. > > 2002-02-11 17:41 tgl > > * src/backend/access/gist/gist.c: Tweak GiST code to work correctly > on machines where 8-byte alignment of pointers is required. Patch > from Teodor Sigaev per pghackers discussion. It's an ugly kluge > but avoids forcing initdb; we'll put a better fix into 7.3 or > later. > > 2002-02-11 16:38 petere > > * src/backend/port/dynloader/freebsd.h: Fix for old FreeBSD > versions that don't have RTLD_GLOBAL > > 2002-02-11 15:10 tgl > > * src/backend/executor/: nodeIndexscan.c, nodeTidscan.c: Repair > problems with EvalPlanQual where target table is scanned as inner > indexscan (ie, one with runtime keys). ExecIndexReScan must > compute or recompute runtime keys even if we are rescanning in the > EPQ case. TidScan seems to have comparable problems. Per bug > noted by Barry Lind 11-Feb-02. > > 2002-02-11 10:19 momjian > > * contrib/pg_upgrade/pg_upgrade: Fix flag handling of pg_upgrade. > > 2002-02-10 19:18 tgl > > * src/bin/pg_dump/: common.c, pg_backup.h, pg_backup_archiver.c, > pg_dump.c, pg_dump.h, pg_dumpall.sh: Be more wary about mixed-case > database names and user names. Get the CREATE DATABASE command > right in pg_dump -C case. > > 2002-02-10 19:14 tgl > > * doc/src/sgml/ref/: pg_dump.sgml, pg_restore.sgml: pg_dump and > pg_restore man pages need to mention that one should restore into a > virgin database, ie, one created from template0, if there are any > site-local additions in template1. > > 2002-02-10 17:56 tgl > > * src/backend/storage/file/fd.c: Don't Assert() that fsync() and > close() never fail; I have seen this crash on Solaris when over > disk quota. Instead, report such failures via elog(DEBUG). > > 2002-02-08 11:30 momjian > > * src/backend/utils/init/findbe.c: Move sys/types.h to top, for > hiroyuki hanai/ FreeBSD. > > 2002-02-08 09:47 momjian > > * contrib/mysql/my2pg.pl: Upgrade my2pg version 1.23. > > 2002-02-07 17:20 tgl > > * src/backend/postmaster/pgstat.c: pgstat's truncation of query > string needs to be multibyte-aware. Patch from sugita@sra.co.jp. > > 2002-02-07 17:11 tgl > > * contrib/: intarray/_int.c, tsearch/README.tsearch, > tsearch/gistidx.c, tsearch/tsearch.sql.in: Repair some problems in > GIST-index contrib modules. Patch from Teodor Sigaev > <teodor@stack.net>. > > 2002-02-06 19:27 inoue > > * src/backend/tcop/utility.c: Removed a check for REINDEX TABLE. > > 2002-02-06 15:29 petere > > * doc/Makefile: Fix for parallel make > > 2002-02-06 12:27 tgl > > * src/bin/pg_dump/: pg_backup_archiver.c, pg_dump.c: Fix failure to > reconnect as sequence's owner before issuing setval(). > > ---------------------------(end of broadcast)--------------------------- > TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org >
-
Re: Time for 7.2.1?
Bruce Momjian <pgman@candle.pha.pa.us> — 2002-03-08T03:36:04Z
I see the patch appeared on patches March 4, and on hackers March 6: http://groups.google.com/groups?hl=en&q=BUG%23599&btnG=Google+Search&meta=group%3Dcomp.databases.postgresql.* I was hoping our ecpg guy could take a look at it before it was applied. I will apply it in a day or so. It is in the patches queue just added todo: http://candle.pha.pa.us/cgi-bin/pgpatches --------------------------------------------------------------------------- Nicolas Bazin wrote: > The ecpg Patch I send correct a bug in the pre-processor that it would be > nice to have in this release. > ----- Original Message ----- > From: "Tom Lane" <tgl@sss.pgh.pa.us> > To: <pgsql-hackers@postgreSQL.org> > Sent: Friday, March 08, 2002 12:28 PM > Subject: [HACKERS] Time for 7.2.1? > > > > Seems like it's about time to release 7.2.1. We have enough > > post-release patches in there that a dot-release is clearly needed > > (particularly for the pg_dump-related issues). And it seems like > > not too much new stuff is coming in. Does anyone have any issues > > outstanding that need to be dealt with before 7.2.1? > > > > regards, tom lane > > > > > > Post-release patches in the 7.2 branch: > > > > 2002-03-05 01:10 momjian > > > > * contrib/tsearch/dict/porter_english.dct (REL7_2_STABLE): Please, > > apply attached patch for contrib/tsearch to 7.2.1 and current CVS. > > It fix english stemmer's problem with ending words like > > 'technology'. > > > > We have found one more bug in english stemmer. The bug is with > > 'irregular' english words like 'skies' -> 'sky'. Please, apply > > attached cumulative patch to 7.2.1 and current CVS instead > > previous one. > > > > Thank to Thomas T. Thai <tom@minnesota.com> for hard testing. This > > kind of bug has significance only for dump/reload database and > > viewing, but searching/indexing works right. > > > > Teodor Sigaev > > > > 2002-03-05 00:13 tgl > > > > * src/backend/optimizer/prep/prepunion.c (REL7_2_STABLE): Previous > > patch to mark UNION outputs with common typmod (if any) breaks > > three-or-more-way UNIONs, as per example from Josh Berkus. Cause > > is a fragile assumption that one tlist's entries will exactly match > > another. Restructure code to make that assumption a little less > > fragile. > > > > 2002-03-04 22:45 ishii > > > > * src/: backend/utils/adt/timestamp.c, > > test/regress/expected/timestamp.out, > > test/regress/expected/timestamptz.out (REL7_2_STABLE): A backport > > patch: > > > > Fix bug in extract/date_part for milliseconds/miscroseconds and > > timestamp/timestamptz combo. Now extract/date_part returns > > seconds*1000 or 1000000 + fraction part as the manual stats. > > regression test are also fixed. > > > > See the thread in pgsql-hackers: > > > > Subject: Re: [HACKERS] timestamp_part() bug? Date: Sat, 02 Mar 2002 > > 11:29:53 +0900 > > > > 2002-03-04 12:47 tgl > > > > * doc/FAQ_Solaris (REL7_2_STABLE): Update FAQ_Solaris with info > > about gcc 2.95.1 problems and how to work around 64-bit vsnprintf > > bug. > > > > 2002-02-27 18:17 tgl > > > > * src/backend/tcop/postgres.c (REL7_2_STABLE): Back-patch fix for > > errors reported at transaction end. > > > > 2002-02-26 20:47 ishii > > > > * src/backend/commands/copy.c (REL7_2_STABLE): Back-patch fix for > > followings: > > > > Fix bug in COPY FROM when DELIMITER is not in ASCII range. See > > pgsql-bugs/pgsql-hackers discussion "COPY FROM is not 8bit clean" > > around 2002/02/26 for more details -- Tatsuo Ishii > > > > 2002-02-26 18:48 tgl > > > > * src/: backend/commands/command.c, backend/commands/explain.c, > > backend/executor/functions.c, backend/executor/spi.c, > > backend/nodes/copyfuncs.c, backend/nodes/equalfuncs.c, > > backend/nodes/readfuncs.c, backend/parser/analyze.c, > > backend/tcop/dest.c, backend/tcop/postgres.c, > > backend/tcop/pquery.c, backend/tcop/utility.c, > > include/commands/command.h, include/nodes/parsenodes.h, > > include/tcop/dest.h, include/tcop/pquery.h, include/tcop/utility.h > > (REL7_2_STABLE): Back-patch fix for command completion report > > handling. This is primarily needed so that INSERTing a row still > > reports the row's OID even when there are ON INSERT rules firing > > additional queries. > > > > 2002-02-25 16:37 tgl > > > > * src/bin/psql/command.c (REL7_2_STABLE): Tweak psql's \connect > > command to not downcase unquoted database and user names. This is > > a temporary measure to allow backwards compatibility with 7.2 and > > earlier pg_dump. 7.2.1 and later pg_dump will double-quote mixed > > case names in \connect. Once we feel that older dumps are not a > > problem anymore, we can revert this change and treat \connect > > arguments as normal SQL identifiers. > > > > 2002-02-25 15:07 momjian > > > > * src/backend/libpq/auth.c (REL7_2_STABLE): Fix for PAM error > > message display: > > > > > and that the right fix is to make each of the subsequent calls be > > in > > > this same pattern, not to try to emulate their nonsensical style. > > > > Dominic J. Eidson > > > > 2002-02-25 11:22 thomas > > > > * src/backend/utils/adt/datetime.c (REL7_2_STABLE): Add a large > > number of time zones to the lookup table. Fix a few > > apparently-wrong TZ vs DTZ declarations. Same patch as added to > > HEAD. > > > > 2002-02-22 10:40 momjian > > > > * src/include/libpq/pqsignal.h (REL7_2_STABLE): We had a problem > > with to compile pgsql-7.2 under SW-8.0. In the mailing lists I > > found no informations. See note for further informations. > > > > Add missing AuthBlockSig. > > > > regards Heiko > > > > 2002-02-22 08:02 momjian > > > > * doc/: FAQ_russian, src/FAQ/FAQ_russian.html (REL7_2_STABLE): > > BACKPATCH: > > > > Add Russian FAQ to 7.2.1. Why not? > > > > 2002-02-22 01:08 momjian > > > > * contrib/btree_gist/btree_gist.c (REL7_2_STABLE): BACKPATCH: > > > > Please, apply attached patch of contrib/btree_gist to 7.2.1 and > > current cvs. The patch fixes memory leak during creation GiST > > index on timestamp column. > > > > Thank you. > > > > -- Teodor Sigaev teodor@stack.net > > > > 2002-02-19 17:19 tgl > > > > * src/backend/utils/adt/cash.c (REL7_2_STABLE): Avoid failures in > > cash_out and cash_words for INT_MIN. Also, 'fourty' -> 'forty'. > > > > 2002-02-18 11:04 tgl > > > > * src/backend/commands/analyze.c (REL7_2_STABLE): Replace > > number-of-distinct-values estimator equation, per recent pghackers > > discussion. > > > > 2002-02-17 23:12 ishii > > > > * src/bin/pgaccess/lib/tables.tcl (REL7_2_STABLE): Fix > > kanji-coversion key binding. This has been broken since 7.1 Per > > Yoshinori Ariie's report. > > > > 2002-02-17 08:29 momjian > > > > * doc/src/sgml/ref/alter_table.sgml: Fix SGML typo in previous > > patch. > > > > 2002-02-17 06:50 momjian > > > > * doc/src/sgml/ref/alter_table.sgml: I think it's important that > > it's actually documented that they can add primary keys after the > > fact! > > > > Also, we need to add regression tests for alter table / add primary > > key and alter table / drop constraint. These shouldn't be added > > until 7.3 tho methinks... > > > > Chris > > > > 2002-02-16 18:45 momjian > > > > * doc/src/sgml/ref/alter_table.sgml: Clarify params to ALTER TABLE > > to clearly show single parameters. > > > > e.g. table contraint definition -> table_constraint_definition. > > > > 2002-02-15 12:46 petere > > > > * src/interfaces/ecpg/preproc/pgc.l: Remove warning about automatic > > inclusion of sqlca. > > > > 2002-02-14 10:24 tgl > > > > * src/: backend/commands/command.c, backend/executor/spi.c, > > backend/utils/mmgr/portalmem.c, include/utils/portal.h: Ensure that > > a cursor is scanned under the same scanCommandId it was originally > > created with, so that the set of visible tuples does not change as > > a result of other activity. This essentially makes PG cursors > > INSENSITIVE per the SQL92 definition. See bug report of 13-Feb-02. > > > > 2002-02-13 14:32 tgl > > > > * doc/src/sgml/ref/createuser.sgml: Point out that --adduser > > actually makes the new user a superuser. This was mentioned on the > > man page for the underlying CREATE USER command, but it should be > > explained here too. > > > > 2002-02-12 18:39 tgl > > > > * src/backend/port/dynloader/: README.dlfcn.aix, aix.h, bsdi.h, > > dgux.h, freebsd.h, irix5.h, linux.h, netbsd.h, openbsd.h, osf.h, > > sco.h, solaris.h, sunos4.h, svr4.h, univel.h, unixware.h, win.h: > > Use RTLD_NOW, not RTLD_LAZY, as binding mode for dlopen() on all > > platforms. This restores the Linux behavior to what it was in PG > > 7.0 and 7.1, and causes other platforms to agree. (Other > > well-tested platforms like HPUX were doing it this way already.) > > Per pghackers discussion over the past month or so. > > > > 2002-02-12 17:35 tgl > > > > * doc/FAQ_Solaris: Add warning not to use /usr/ucb/cc on Solaris. > > > > 2002-02-12 17:25 momjian > > > > * doc/src/sgml/advanced.sgml: Fix tutorial for references problem, > > from rainer.tammer@spg.schulergroup.com > > > > 2002-02-12 16:25 tgl > > > > * doc/src/sgml/ref/copy.sgml, src/backend/commands/copy.c: Modify > > COPY TO to emit carriage returns and newlines as backslash escapes > > (backslash-r, backslash-n) for protection against > > newline-conversion munging. In future we will also tweak COPY > > FROM, but this part of the change should be backwards-compatible. > > Per pghackers discussion. Also, update COPY reference page to > > describe the backslash conversions more completely and accurately. > > > > 2002-02-11 18:25 momjian > > > > * doc/src/sgml/wal.sgml: Update wal files computation > > documentation. > > > > 2002-02-11 17:41 tgl > > > > * src/backend/access/gist/gist.c: Tweak GiST code to work correctly > > on machines where 8-byte alignment of pointers is required. Patch > > from Teodor Sigaev per pghackers discussion. It's an ugly kluge > > but avoids forcing initdb; we'll put a better fix into 7.3 or > > later. > > > > 2002-02-11 16:38 petere > > > > * src/backend/port/dynloader/freebsd.h: Fix for old FreeBSD > > versions that don't have RTLD_GLOBAL > > > > 2002-02-11 15:10 tgl > > > > * src/backend/executor/: nodeIndexscan.c, nodeTidscan.c: Repair > > problems with EvalPlanQual where target table is scanned as inner > > indexscan (ie, one with runtime keys). ExecIndexReScan must > > compute or recompute runtime keys even if we are rescanning in the > > EPQ case. TidScan seems to have comparable problems. Per bug > > noted by Barry Lind 11-Feb-02. > > > > 2002-02-11 10:19 momjian > > > > * contrib/pg_upgrade/pg_upgrade: Fix flag handling of pg_upgrade. > > > > 2002-02-10 19:18 tgl > > > > * src/bin/pg_dump/: common.c, pg_backup.h, pg_backup_archiver.c, > > pg_dump.c, pg_dump.h, pg_dumpall.sh: Be more wary about mixed-case > > database names and user names. Get the CREATE DATABASE command > > right in pg_dump -C case. > > > > 2002-02-10 19:14 tgl > > > > * doc/src/sgml/ref/: pg_dump.sgml, pg_restore.sgml: pg_dump and > > pg_restore man pages need to mention that one should restore into a > > virgin database, ie, one created from template0, if there are any > > site-local additions in template1. > > > > 2002-02-10 17:56 tgl > > > > * src/backend/storage/file/fd.c: Don't Assert() that fsync() and > > close() never fail; I have seen this crash on Solaris when over > > disk quota. Instead, report such failures via elog(DEBUG). > > > > 2002-02-08 11:30 momjian > > > > * src/backend/utils/init/findbe.c: Move sys/types.h to top, for > > hiroyuki hanai/ FreeBSD. > > > > 2002-02-08 09:47 momjian > > > > * contrib/mysql/my2pg.pl: Upgrade my2pg version 1.23. > > > > 2002-02-07 17:20 tgl > > > > * src/backend/postmaster/pgstat.c: pgstat's truncation of query > > string needs to be multibyte-aware. Patch from sugita@sra.co.jp. > > > > 2002-02-07 17:11 tgl > > > > * contrib/: intarray/_int.c, tsearch/README.tsearch, > > tsearch/gistidx.c, tsearch/tsearch.sql.in: Repair some problems in > > GIST-index contrib modules. Patch from Teodor Sigaev > > <teodor@stack.net>. > > > > 2002-02-06 19:27 inoue > > > > * src/backend/tcop/utility.c: Removed a check for REINDEX TABLE. > > > > 2002-02-06 15:29 petere > > > > * doc/Makefile: Fix for parallel make > > > > 2002-02-06 12:27 tgl > > > > * src/bin/pg_dump/: pg_backup_archiver.c, pg_dump.c: Fix failure to > > reconnect as sequence's owner before issuing setval(). > > > > ---------------------------(end of broadcast)--------------------------- > > TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org > > > > > > ---------------------------(end of broadcast)--------------------------- > TIP 4: Don't 'kill -9' the postmaster > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
-
Re: Time for 7.2.1?
Bruce Momjian <pgman@candle.pha.pa.us> — 2002-03-08T03:41:44Z
Sorry, should have been clearer. I don't think the ecpg patch qualifies as a major bug that should be fixed in 7.2.1. It will appear in 7.3. --------------------------------------------------------------------------- Bruce Momjian wrote: > > I see the patch appeared on patches March 4, and on hackers March 6: > > http://groups.google.com/groups?hl=en&q=BUG%23599&btnG=Google+Search&meta=group%3Dcomp.databases.postgresql.* > > I was hoping our ecpg guy could take a look at it before it was applied. > I will apply it in a day or so. It is in the patches queue just added > todo: > > http://candle.pha.pa.us/cgi-bin/pgpatches -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
-
Re: Time for 7.2.1?
Tom Lane <tgl@sss.pgh.pa.us> — 2002-03-08T04:12:09Z
Bruce Momjian <pgman@candle.pha.pa.us> writes: > Sorry, should have been clearer. I don't think the ecpg patch qualifies > as a major bug that should be fixed in 7.2.1. Not unless Meskes thinks so, anyway ... regards, tom lane
-
Re: Time for 7.2.1?
Teodor Sigaev <teodor@stack.net> — 2002-03-11T16:39:45Z
Sorry, one more patch for tsearch. Pleas apply it for 7.2.1 and current CVS. Patch fixes using lc.lang instead of lc.lc_ctype. Thank you. Tom Lane wrote: > Seems like it's about time to release 7.2.1. We have enough > post-release patches in there that a dot-release is clearly needed > (particularly for the pg_dump-related issues). And it seems like > not too much new stuff is coming in. Does anyone have any issues > outstanding that need to be dealt with before 7.2.1? > > regards, tom lane > > > Post-release patches in the 7.2 branch: > > 2002-03-05 01:10 momjian > > * contrib/tsearch/dict/porter_english.dct (REL7_2_STABLE): Please, > apply attached patch for contrib/tsearch to 7.2.1 and current CVS. > It fix english stemmer's problem with ending words like > 'technology'. > > We have found one more bug in english stemmer. The bug is with > 'irregular' english words like 'skies' -> 'sky'. Please, apply > attached cumulative patch to 7.2.1 and current CVS instead > previous one. > > Thank to Thomas T. Thai <tom@minnesota.com> for hard testing. This > kind of bug has significance only for dump/reload database and > viewing, but searching/indexing works right. > > Teodor Sigaev > > 2002-03-05 00:13 tgl > > * src/backend/optimizer/prep/prepunion.c (REL7_2_STABLE): Previous > patch to mark UNION outputs with common typmod (if any) breaks > three-or-more-way UNIONs, as per example from Josh Berkus. Cause > is a fragile assumption that one tlist's entries will exactly match > another. Restructure code to make that assumption a little less > fragile. > > 2002-03-04 22:45 ishii > > * src/: backend/utils/adt/timestamp.c, > test/regress/expected/timestamp.out, > test/regress/expected/timestamptz.out (REL7_2_STABLE): A backport > patch: > > Fix bug in extract/date_part for milliseconds/miscroseconds and > timestamp/timestamptz combo. Now extract/date_part returns > seconds*1000 or 1000000 + fraction part as the manual stats. > regression test are also fixed. > > See the thread in pgsql-hackers: > > Subject: Re: [HACKERS] timestamp_part() bug? Date: Sat, 02 Mar 2002 > 11:29:53 +0900 > > 2002-03-04 12:47 tgl > > * doc/FAQ_Solaris (REL7_2_STABLE): Update FAQ_Solaris with info > about gcc 2.95.1 problems and how to work around 64-bit vsnprintf > bug. > > 2002-02-27 18:17 tgl > > * src/backend/tcop/postgres.c (REL7_2_STABLE): Back-patch fix for > errors reported at transaction end. > > 2002-02-26 20:47 ishii > > * src/backend/commands/copy.c (REL7_2_STABLE): Back-patch fix for > followings: > > Fix bug in COPY FROM when DELIMITER is not in ASCII range. See > pgsql-bugs/pgsql-hackers discussion "COPY FROM is not 8bit clean" > around 2002/02/26 for more details -- Tatsuo Ishii > > 2002-02-26 18:48 tgl > > * src/: backend/commands/command.c, backend/commands/explain.c, > backend/executor/functions.c, backend/executor/spi.c, > backend/nodes/copyfuncs.c, backend/nodes/equalfuncs.c, > backend/nodes/readfuncs.c, backend/parser/analyze.c, > backend/tcop/dest.c, backend/tcop/postgres.c, > backend/tcop/pquery.c, backend/tcop/utility.c, > include/commands/command.h, include/nodes/parsenodes.h, > include/tcop/dest.h, include/tcop/pquery.h, include/tcop/utility.h > (REL7_2_STABLE): Back-patch fix for command completion report > handling. This is primarily needed so that INSERTing a row still > reports the row's OID even when there are ON INSERT rules firing > additional queries. > > 2002-02-25 16:37 tgl > > * src/bin/psql/command.c (REL7_2_STABLE): Tweak psql's \connect > command to not downcase unquoted database and user names. This is > a temporary measure to allow backwards compatibility with 7.2 and > earlier pg_dump. 7.2.1 and later pg_dump will double-quote mixed > case names in \connect. Once we feel that older dumps are not a > problem anymore, we can revert this change and treat \connect > arguments as normal SQL identifiers. > > 2002-02-25 15:07 momjian > > * src/backend/libpq/auth.c (REL7_2_STABLE): Fix for PAM error > message display: > > > and that the right fix is to make each of the subsequent calls be > in > > this same pattern, not to try to emulate their nonsensical style. > > Dominic J. Eidson > > 2002-02-25 11:22 thomas > > * src/backend/utils/adt/datetime.c (REL7_2_STABLE): Add a large > number of time zones to the lookup table. Fix a few > apparently-wrong TZ vs DTZ declarations. Same patch as added to > HEAD. > > 2002-02-22 10:40 momjian > > * src/include/libpq/pqsignal.h (REL7_2_STABLE): We had a problem > with to compile pgsql-7.2 under SW-8.0. In the mailing lists I > found no informations. See note for further informations. > > Add missing AuthBlockSig. > > regards Heiko > > 2002-02-22 08:02 momjian > > * doc/: FAQ_russian, src/FAQ/FAQ_russian.html (REL7_2_STABLE): > BACKPATCH: > > Add Russian FAQ to 7.2.1. Why not? > > 2002-02-22 01:08 momjian > > * contrib/btree_gist/btree_gist.c (REL7_2_STABLE): BACKPATCH: > > Please, apply attached patch of contrib/btree_gist to 7.2.1 and > current cvs. The patch fixes memory leak during creation GiST > index on timestamp column. > > Thank you. > > -- Teodor Sigaev teodor@stack.net > > 2002-02-19 17:19 tgl > > * src/backend/utils/adt/cash.c (REL7_2_STABLE): Avoid failures in > cash_out and cash_words for INT_MIN. Also, 'fourty' -> 'forty'. > > 2002-02-18 11:04 tgl > > * src/backend/commands/analyze.c (REL7_2_STABLE): Replace > number-of-distinct-values estimator equation, per recent pghackers > discussion. > > 2002-02-17 23:12 ishii > > * src/bin/pgaccess/lib/tables.tcl (REL7_2_STABLE): Fix > kanji-coversion key binding. This has been broken since 7.1 Per > Yoshinori Ariie's report. > > 2002-02-17 08:29 momjian > > * doc/src/sgml/ref/alter_table.sgml: Fix SGML typo in previous > patch. > > 2002-02-17 06:50 momjian > > * doc/src/sgml/ref/alter_table.sgml: I think it's important that > it's actually documented that they can add primary keys after the > fact! > > Also, we need to add regression tests for alter table / add primary > key and alter table / drop constraint. These shouldn't be added > until 7.3 tho methinks... > > Chris > > 2002-02-16 18:45 momjian > > * doc/src/sgml/ref/alter_table.sgml: Clarify params to ALTER TABLE > to clearly show single parameters. > > e.g. table contraint definition -> table_constraint_definition. > > 2002-02-15 12:46 petere > > * src/interfaces/ecpg/preproc/pgc.l: Remove warning about automatic > inclusion of sqlca. > > 2002-02-14 10:24 tgl > > * src/: backend/commands/command.c, backend/executor/spi.c, > backend/utils/mmgr/portalmem.c, include/utils/portal.h: Ensure that > a cursor is scanned under the same scanCommandId it was originally > created with, so that the set of visible tuples does not change as > a result of other activity. This essentially makes PG cursors > INSENSITIVE per the SQL92 definition. See bug report of 13-Feb-02. > > 2002-02-13 14:32 tgl > > * doc/src/sgml/ref/createuser.sgml: Point out that --adduser > actually makes the new user a superuser. This was mentioned on the > man page for the underlying CREATE USER command, but it should be > explained here too. > > 2002-02-12 18:39 tgl > > * src/backend/port/dynloader/: README.dlfcn.aix, aix.h, bsdi.h, > dgux.h, freebsd.h, irix5.h, linux.h, netbsd.h, openbsd.h, osf.h, > sco.h, solaris.h, sunos4.h, svr4.h, univel.h, unixware.h, win.h: > Use RTLD_NOW, not RTLD_LAZY, as binding mode for dlopen() on all > platforms. This restores the Linux behavior to what it was in PG > 7.0 and 7.1, and causes other platforms to agree. (Other > well-tested platforms like HPUX were doing it this way already.) > Per pghackers discussion over the past month or so. > > 2002-02-12 17:35 tgl > > * doc/FAQ_Solaris: Add warning not to use /usr/ucb/cc on Solaris. > > 2002-02-12 17:25 momjian > > * doc/src/sgml/advanced.sgml: Fix tutorial for references problem, > from rainer.tammer@spg.schulergroup.com > > 2002-02-12 16:25 tgl > > * doc/src/sgml/ref/copy.sgml, src/backend/commands/copy.c: Modify > COPY TO to emit carriage returns and newlines as backslash escapes > (backslash-r, backslash-n) for protection against > newline-conversion munging. In future we will also tweak COPY > FROM, but this part of the change should be backwards-compatible. > Per pghackers discussion. Also, update COPY reference page to > describe the backslash conversions more completely and accurately. > > 2002-02-11 18:25 momjian > > * doc/src/sgml/wal.sgml: Update wal files computation > documentation. > > 2002-02-11 17:41 tgl > > * src/backend/access/gist/gist.c: Tweak GiST code to work correctly > on machines where 8-byte alignment of pointers is required. Patch > from Teodor Sigaev per pghackers discussion. It's an ugly kluge > but avoids forcing initdb; we'll put a better fix into 7.3 or > later. > > 2002-02-11 16:38 petere > > * src/backend/port/dynloader/freebsd.h: Fix for old FreeBSD > versions that don't have RTLD_GLOBAL > > 2002-02-11 15:10 tgl > > * src/backend/executor/: nodeIndexscan.c, nodeTidscan.c: Repair > problems with EvalPlanQual where target table is scanned as inner > indexscan (ie, one with runtime keys). ExecIndexReScan must > compute or recompute runtime keys even if we are rescanning in the > EPQ case. TidScan seems to have comparable problems. Per bug > noted by Barry Lind 11-Feb-02. > > 2002-02-11 10:19 momjian > > * contrib/pg_upgrade/pg_upgrade: Fix flag handling of pg_upgrade. > > 2002-02-10 19:18 tgl > > * src/bin/pg_dump/: common.c, pg_backup.h, pg_backup_archiver.c, > pg_dump.c, pg_dump.h, pg_dumpall.sh: Be more wary about mixed-case > database names and user names. Get the CREATE DATABASE command > right in pg_dump -C case. > > 2002-02-10 19:14 tgl > > * doc/src/sgml/ref/: pg_dump.sgml, pg_restore.sgml: pg_dump and > pg_restore man pages need to mention that one should restore into a > virgin database, ie, one created from template0, if there are any > site-local additions in template1. > > 2002-02-10 17:56 tgl > > * src/backend/storage/file/fd.c: Don't Assert() that fsync() and > close() never fail; I have seen this crash on Solaris when over > disk quota. Instead, report such failures via elog(DEBUG). > > 2002-02-08 11:30 momjian > > * src/backend/utils/init/findbe.c: Move sys/types.h to top, for > hiroyuki hanai/ FreeBSD. > > 2002-02-08 09:47 momjian > > * contrib/mysql/my2pg.pl: Upgrade my2pg version 1.23. > > 2002-02-07 17:20 tgl > > * src/backend/postmaster/pgstat.c: pgstat's truncation of query > string needs to be multibyte-aware. Patch from sugita@sra.co.jp. > > 2002-02-07 17:11 tgl > > * contrib/: intarray/_int.c, tsearch/README.tsearch, > tsearch/gistidx.c, tsearch/tsearch.sql.in: Repair some problems in > GIST-index contrib modules. Patch from Teodor Sigaev > <teodor@stack.net>. > > 2002-02-06 19:27 inoue > > * src/backend/tcop/utility.c: Removed a check for REINDEX TABLE. > > 2002-02-06 15:29 petere > > * doc/Makefile: Fix for parallel make > > 2002-02-06 12:27 tgl > > * src/bin/pg_dump/: pg_backup_archiver.c, pg_dump.c: Fix failure to > reconnect as sequence's owner before issuing setval(). > > ---------------------------(end of broadcast)--------------------------- > TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org > > -- Teodor Sigaev teodor@stack.net
-
Re: Time for 7.2.1?
Bruce Momjian <pgman@candle.pha.pa.us> — 2002-03-11T16:55:41Z
Applied to current and 7.2.X. Thanks. (No delay for /contrib commits from maintainers.) --------------------------------------------------------------------------- Teodor Sigaev wrote: > Sorry, one more patch for tsearch. > > Pleas apply it for 7.2.1 and current CVS. > > Patch fixes using lc.lang instead of lc.lc_ctype. > Thank you. > > > Tom Lane wrote: > > Seems like it's about time to release 7.2.1. We have enough > > post-release patches in there that a dot-release is clearly needed > > (particularly for the pg_dump-related issues). And it seems like > > not too much new stuff is coming in. Does anyone have any issues > > outstanding that need to be dealt with before 7.2.1? > > > > regards, tom lane > > > > > > Post-release patches in the 7.2 branch: > > > > 2002-03-05 01:10 momjian > > > > * contrib/tsearch/dict/porter_english.dct (REL7_2_STABLE): Please, > > apply attached patch for contrib/tsearch to 7.2.1 and current CVS. > > It fix english stemmer's problem with ending words like > > 'technology'. > > > > We have found one more bug in english stemmer. The bug is with > > 'irregular' english words like 'skies' -> 'sky'. Please, apply > > attached cumulative patch to 7.2.1 and current CVS instead > > previous one. > > > > Thank to Thomas T. Thai <tom@minnesota.com> for hard testing. This > > kind of bug has significance only for dump/reload database and > > viewing, but searching/indexing works right. > > > > Teodor Sigaev > > > > 2002-03-05 00:13 tgl > > > > * src/backend/optimizer/prep/prepunion.c (REL7_2_STABLE): Previous > > patch to mark UNION outputs with common typmod (if any) breaks > > three-or-more-way UNIONs, as per example from Josh Berkus. Cause > > is a fragile assumption that one tlist's entries will exactly match > > another. Restructure code to make that assumption a little less > > fragile. > > > > 2002-03-04 22:45 ishii > > > > * src/: backend/utils/adt/timestamp.c, > > test/regress/expected/timestamp.out, > > test/regress/expected/timestamptz.out (REL7_2_STABLE): A backport > > patch: > > > > Fix bug in extract/date_part for milliseconds/miscroseconds and > > timestamp/timestamptz combo. Now extract/date_part returns > > seconds*1000 or 1000000 + fraction part as the manual stats. > > regression test are also fixed. > > > > See the thread in pgsql-hackers: > > > > Subject: Re: [HACKERS] timestamp_part() bug? Date: Sat, 02 Mar 2002 > > 11:29:53 +0900 > > > > 2002-03-04 12:47 tgl > > > > * doc/FAQ_Solaris (REL7_2_STABLE): Update FAQ_Solaris with info > > about gcc 2.95.1 problems and how to work around 64-bit vsnprintf > > bug. > > > > 2002-02-27 18:17 tgl > > > > * src/backend/tcop/postgres.c (REL7_2_STABLE): Back-patch fix for > > errors reported at transaction end. > > > > 2002-02-26 20:47 ishii > > > > * src/backend/commands/copy.c (REL7_2_STABLE): Back-patch fix for > > followings: > > > > Fix bug in COPY FROM when DELIMITER is not in ASCII range. See > > pgsql-bugs/pgsql-hackers discussion "COPY FROM is not 8bit clean" > > around 2002/02/26 for more details -- Tatsuo Ishii > > > > 2002-02-26 18:48 tgl > > > > * src/: backend/commands/command.c, backend/commands/explain.c, > > backend/executor/functions.c, backend/executor/spi.c, > > backend/nodes/copyfuncs.c, backend/nodes/equalfuncs.c, > > backend/nodes/readfuncs.c, backend/parser/analyze.c, > > backend/tcop/dest.c, backend/tcop/postgres.c, > > backend/tcop/pquery.c, backend/tcop/utility.c, > > include/commands/command.h, include/nodes/parsenodes.h, > > include/tcop/dest.h, include/tcop/pquery.h, include/tcop/utility.h > > (REL7_2_STABLE): Back-patch fix for command completion report > > handling. This is primarily needed so that INSERTing a row still > > reports the row's OID even when there are ON INSERT rules firing > > additional queries. > > > > 2002-02-25 16:37 tgl > > > > * src/bin/psql/command.c (REL7_2_STABLE): Tweak psql's \connect > > command to not downcase unquoted database and user names. This is > > a temporary measure to allow backwards compatibility with 7.2 and > > earlier pg_dump. 7.2.1 and later pg_dump will double-quote mixed > > case names in \connect. Once we feel that older dumps are not a > > problem anymore, we can revert this change and treat \connect > > arguments as normal SQL identifiers. > > > > 2002-02-25 15:07 momjian > > > > * src/backend/libpq/auth.c (REL7_2_STABLE): Fix for PAM error > > message display: > > > > > and that the right fix is to make each of the subsequent calls be > > in > > > this same pattern, not to try to emulate their nonsensical style. > > > > Dominic J. Eidson > > > > 2002-02-25 11:22 thomas > > > > * src/backend/utils/adt/datetime.c (REL7_2_STABLE): Add a large > > number of time zones to the lookup table. Fix a few > > apparently-wrong TZ vs DTZ declarations. Same patch as added to > > HEAD. > > > > 2002-02-22 10:40 momjian > > > > * src/include/libpq/pqsignal.h (REL7_2_STABLE): We had a problem > > with to compile pgsql-7.2 under SW-8.0. In the mailing lists I > > found no informations. See note for further informations. > > > > Add missing AuthBlockSig. > > > > regards Heiko > > > > 2002-02-22 08:02 momjian > > > > * doc/: FAQ_russian, src/FAQ/FAQ_russian.html (REL7_2_STABLE): > > BACKPATCH: > > > > Add Russian FAQ to 7.2.1. Why not? > > > > 2002-02-22 01:08 momjian > > > > * contrib/btree_gist/btree_gist.c (REL7_2_STABLE): BACKPATCH: > > > > Please, apply attached patch of contrib/btree_gist to 7.2.1 and > > current cvs. The patch fixes memory leak during creation GiST > > index on timestamp column. > > > > Thank you. > > > > -- Teodor Sigaev teodor@stack.net > > > > 2002-02-19 17:19 tgl > > > > * src/backend/utils/adt/cash.c (REL7_2_STABLE): Avoid failures in > > cash_out and cash_words for INT_MIN. Also, 'fourty' -> 'forty'. > > > > 2002-02-18 11:04 tgl > > > > * src/backend/commands/analyze.c (REL7_2_STABLE): Replace > > number-of-distinct-values estimator equation, per recent pghackers > > discussion. > > > > 2002-02-17 23:12 ishii > > > > * src/bin/pgaccess/lib/tables.tcl (REL7_2_STABLE): Fix > > kanji-coversion key binding. This has been broken since 7.1 Per > > Yoshinori Ariie's report. > > > > 2002-02-17 08:29 momjian > > > > * doc/src/sgml/ref/alter_table.sgml: Fix SGML typo in previous > > patch. > > > > 2002-02-17 06:50 momjian > > > > * doc/src/sgml/ref/alter_table.sgml: I think it's important that > > it's actually documented that they can add primary keys after the > > fact! > > > > Also, we need to add regression tests for alter table / add primary > > key and alter table / drop constraint. These shouldn't be added > > until 7.3 tho methinks... > > > > Chris > > > > 2002-02-16 18:45 momjian > > > > * doc/src/sgml/ref/alter_table.sgml: Clarify params to ALTER TABLE > > to clearly show single parameters. > > > > e.g. table contraint definition -> table_constraint_definition. > > > > 2002-02-15 12:46 petere > > > > * src/interfaces/ecpg/preproc/pgc.l: Remove warning about automatic > > inclusion of sqlca. > > > > 2002-02-14 10:24 tgl > > > > * src/: backend/commands/command.c, backend/executor/spi.c, > > backend/utils/mmgr/portalmem.c, include/utils/portal.h: Ensure that > > a cursor is scanned under the same scanCommandId it was originally > > created with, so that the set of visible tuples does not change as > > a result of other activity. This essentially makes PG cursors > > INSENSITIVE per the SQL92 definition. See bug report of 13-Feb-02. > > > > 2002-02-13 14:32 tgl > > > > * doc/src/sgml/ref/createuser.sgml: Point out that --adduser > > actually makes the new user a superuser. This was mentioned on the > > man page for the underlying CREATE USER command, but it should be > > explained here too. > > > > 2002-02-12 18:39 tgl > > > > * src/backend/port/dynloader/: README.dlfcn.aix, aix.h, bsdi.h, > > dgux.h, freebsd.h, irix5.h, linux.h, netbsd.h, openbsd.h, osf.h, > > sco.h, solaris.h, sunos4.h, svr4.h, univel.h, unixware.h, win.h: > > Use RTLD_NOW, not RTLD_LAZY, as binding mode for dlopen() on all > > platforms. This restores the Linux behavior to what it was in PG > > 7.0 and 7.1, and causes other platforms to agree. (Other > > well-tested platforms like HPUX were doing it this way already.) > > Per pghackers discussion over the past month or so. > > > > 2002-02-12 17:35 tgl > > > > * doc/FAQ_Solaris: Add warning not to use /usr/ucb/cc on Solaris. > > > > 2002-02-12 17:25 momjian > > > > * doc/src/sgml/advanced.sgml: Fix tutorial for references problem, > > from rainer.tammer@spg.schulergroup.com > > > > 2002-02-12 16:25 tgl > > > > * doc/src/sgml/ref/copy.sgml, src/backend/commands/copy.c: Modify > > COPY TO to emit carriage returns and newlines as backslash escapes > > (backslash-r, backslash-n) for protection against > > newline-conversion munging. In future we will also tweak COPY > > FROM, but this part of the change should be backwards-compatible. > > Per pghackers discussion. Also, update COPY reference page to > > describe the backslash conversions more completely and accurately. > > > > 2002-02-11 18:25 momjian > > > > * doc/src/sgml/wal.sgml: Update wal files computation > > documentation. > > > > 2002-02-11 17:41 tgl > > > > * src/backend/access/gist/gist.c: Tweak GiST code to work correctly > > on machines where 8-byte alignment of pointers is required. Patch > > from Teodor Sigaev per pghackers discussion. It's an ugly kluge > > but avoids forcing initdb; we'll put a better fix into 7.3 or > > later. > > > > 2002-02-11 16:38 petere > > > > * src/backend/port/dynloader/freebsd.h: Fix for old FreeBSD > > versions that don't have RTLD_GLOBAL > > > > 2002-02-11 15:10 tgl > > > > * src/backend/executor/: nodeIndexscan.c, nodeTidscan.c: Repair > > problems with EvalPlanQual where target table is scanned as inner > > indexscan (ie, one with runtime keys). ExecIndexReScan must > > compute or recompute runtime keys even if we are rescanning in the > > EPQ case. TidScan seems to have comparable problems. Per bug > > noted by Barry Lind 11-Feb-02. > > > > 2002-02-11 10:19 momjian > > > > * contrib/pg_upgrade/pg_upgrade: Fix flag handling of pg_upgrade. > > > > 2002-02-10 19:18 tgl > > > > * src/bin/pg_dump/: common.c, pg_backup.h, pg_backup_archiver.c, > > pg_dump.c, pg_dump.h, pg_dumpall.sh: Be more wary about mixed-case > > database names and user names. Get the CREATE DATABASE command > > right in pg_dump -C case. > > > > 2002-02-10 19:14 tgl > > > > * doc/src/sgml/ref/: pg_dump.sgml, pg_restore.sgml: pg_dump and > > pg_restore man pages need to mention that one should restore into a > > virgin database, ie, one created from template0, if there are any > > site-local additions in template1. > > > > 2002-02-10 17:56 tgl > > > > * src/backend/storage/file/fd.c: Don't Assert() that fsync() and > > close() never fail; I have seen this crash on Solaris when over > > disk quota. Instead, report such failures via elog(DEBUG). > > > > 2002-02-08 11:30 momjian > > > > * src/backend/utils/init/findbe.c: Move sys/types.h to top, for > > hiroyuki hanai/ FreeBSD. > > > > 2002-02-08 09:47 momjian > > > > * contrib/mysql/my2pg.pl: Upgrade my2pg version 1.23. > > > > 2002-02-07 17:20 tgl > > > > * src/backend/postmaster/pgstat.c: pgstat's truncation of query > > string needs to be multibyte-aware. Patch from sugita@sra.co.jp. > > > > 2002-02-07 17:11 tgl > > > > * contrib/: intarray/_int.c, tsearch/README.tsearch, > > tsearch/gistidx.c, tsearch/tsearch.sql.in: Repair some problems in > > GIST-index contrib modules. Patch from Teodor Sigaev > > <teodor@stack.net>. > > > > 2002-02-06 19:27 inoue > > > > * src/backend/tcop/utility.c: Removed a check for REINDEX TABLE. > > > > 2002-02-06 15:29 petere > > > > * doc/Makefile: Fix for parallel make > > > > 2002-02-06 12:27 tgl > > > > * src/bin/pg_dump/: pg_backup_archiver.c, pg_dump.c: Fix failure to > > reconnect as sequence's owner before issuing setval(). > > > > ---------------------------(end of broadcast)--------------------------- > > TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org > > > > > > > -- > Teodor Sigaev > teodor@stack.net > [ application/gzip is not supported, skipping... ] -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
-
Re: Time for 7.2.1?
Thomas F.O'Connell <tfo@monsterlabs.com> — 2002-03-15T17:22:35Z
is there any further word on 7.2.1, at this point? haven't seen mention of it on the list in a while? is it still waiting on something big? -tfo Bruce Momjian wrote: > Applied to current and 7.2.X. Thanks. > > (No delay for /contrib commits from maintainers.)
-
Re: Time for 7.2.1?
Tom Lane <tgl@sss.pgh.pa.us> — 2002-03-15T17:57:32Z
"Thomas F. O'Connell" <tfo@monsterlabs.com> writes: > is there any further word on 7.2.1, at this point? haven't seen mention > of it on the list in a while? is it still waiting on something big? Well, we were gonna release it last weekend, but now it's waiting on sequence fixes (currently being tested). And Lockhart may also wish to hold it up while he looks at the recently reported timestamp_part problem. (Thomas, are you considering backpatching that?) One way or another I'd expect it next week sometime. regards, tom lane
-
Re: Time for 7.2.1?
Thomas Lockhart <thomas@fourpalms.org> — 2002-03-15T18:06:57Z
> Well, we were gonna release it last weekend, but now it's waiting on > sequence fixes (currently being tested). And Lockhart may also wish to > hold it up while he looks at the recently reported timestamp_part > problem. (Thomas, are you considering backpatching that?) One way > or another I'd expect it next week sometime. I'll consider backpatching once I have a chance to dive in. It is somewhat complicated by the fact that my code tree is pretty massively changed in this area as I implement an int64-based date/time storage alternative to the float64 scheme we use now. The alternative would be enabled with something like #ifdef HAVE_INT64_TIMESTAMP. Benefits would include having a predictable precision behavior for all allowed dates and times. - Thomas -
Re: Time for 7.2.1?
Tom Lane <tgl@sss.pgh.pa.us> — 2002-03-15T19:44:33Z
Thomas Lockhart <thomas@fourpalms.org> writes: > It is somewhat complicated by the fact that my code tree is pretty > massively changed in this area as I implement an int64-based date/time > storage alternative to the float64 scheme we use now. The alternative > would be enabled with something like #ifdef HAVE_INT64_TIMESTAMP. > Benefits would include having a predictable precision behavior for all > allowed dates and times. Interesting. But if this is just an #ifdef, I can see some serious problems coming up the first time someone runs a backend compiled with one set of timestamp code in a database created with the other. May I suggest that the timestamp representation be identified in a field added to pg_control? That's how we deal with other options that affect database contents ... regards, tom lane
-
Re: Time for 7.2.1?
Tom Lane <tgl@sss.pgh.pa.us> — 2002-03-17T20:14:00Z
I believe we've now committed fixes for all the "must fix" items there were for 7.2.1. Does anyone have any reasons to hold up 7.2.1 more, or are we ready to go? regards, tom lane
-
Re: Time for 7.2.1?
Bruce Momjian <pgman@candle.pha.pa.us> — 2002-03-17T22:41:29Z
Tom Lane wrote: > I believe we've now committed fixes for all the "must fix" items there > were for 7.2.1. Does anyone have any reasons to hold up 7.2.1 more, > or are we ready to go? I need to brand 7.2.1 --- will do tomorrow. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
-
Re: Time for 7.2.1?
Bruce Momjian <pgman@candle.pha.pa.us> — 2002-03-18T23:12:50Z
OK, I have branded 7.2.1 and updated HISTORY/release.sgml. Do we want any special text about the sequence bug fix, or just mention in the announcement that all 7.2 people should upgrade? --------------------------------------------------------------------------- Bruce Momjian wrote: > Tom Lane wrote: > > I believe we've now committed fixes for all the "must fix" items there > > were for 7.2.1. Does anyone have any reasons to hold up 7.2.1 more, > > or are we ready to go? > > I need to brand 7.2.1 --- will do tomorrow. > > -- > Bruce Momjian | http://candle.pha.pa.us > pgman@candle.pha.pa.us | (610) 853-3000 > + If your life is a hard drive, | 830 Blythe Avenue > + Christ can be your backup. | Drexel Hill, Pennsylvania 19026 > > ---------------------------(end of broadcast)--------------------------- > TIP 6: Have you searched our list archives? > > http://archives.postgresql.org > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
-
Re: Time for 7.2.1?
Tom Lane <tgl@sss.pgh.pa.us> — 2002-03-18T23:51:54Z
Bruce Momjian <pgman@candle.pha.pa.us> writes: > OK, I have branded 7.2.1 and updated HISTORY/release.sgml. Do we want > any special text about the sequence bug fix, or just mention in the > announcement that all 7.2 people should upgrade? The first change item should maybe be more explicit, say Ensure that sequence counters do not go backwards after a crash Otherwise I think it's fine. BTW, the bug exists in 7.1 as well. regards, tom lane
-
Re: Time for 7.2.1?
Bruce Momjian <pgman@candle.pha.pa.us> — 2002-03-19T00:11:46Z
Tom Lane wrote: > Bruce Momjian <pgman@candle.pha.pa.us> writes: > > OK, I have branded 7.2.1 and updated HISTORY/release.sgml. Do we want > > any special text about the sequence bug fix, or just mention in the > > announcement that all 7.2 people should upgrade? > > The first change item should maybe be more explicit, say > > Ensure that sequence counters do not go backwards after a crash > > Otherwise I think it's fine. BTW, the bug exists in 7.1 as well. Done. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
-
Re: Time for 7.2.1?
D'Arcy Cain <darcy@druid.net> — 2002-03-19T09:55:36Z
On March 18, 2002 06:12 pm, Bruce Momjian wrote: > OK, I have branded 7.2.1 and updated HISTORY/release.sgml. Do we want > any special text about the sequence bug fix, or just mention in the > announcement that all 7.2 people should upgrade? Does this mean that I can start putting fixes and upgrades into PyGreSQL? -- D'Arcy J.M. Cain <darcy@{druid|vex}.net> | Democracy is three wolves http://www.druid.net/darcy/ | and a sheep voting on +1 416 425 1212 (DoD#0082) (eNTP) | what's for dinner. -
Re: Time for 7.2.1?
Oleg Bartunov <oleg@sai.msu.su> — 2002-03-19T12:00:36Z
Bruce, we have something to add. It's quite important for users of our tsearch module. Too late ? On Mon, 18 Mar 2002, Bruce Momjian wrote: > > OK, I have branded 7.2.1 and updated HISTORY/release.sgml. Do we want > any special text about the sequence bug fix, or just mention in the > announcement that all 7.2 people should upgrade? > > --------------------------------------------------------------------------- > > Bruce Momjian wrote: > > Tom Lane wrote: > > > I believe we've now committed fixes for all the "must fix" items there > > > were for 7.2.1. Does anyone have any reasons to hold up 7.2.1 more, > > > or are we ready to go? > > > > I need to brand 7.2.1 --- will do tomorrow. > > > > -- > > Bruce Momjian | http://candle.pha.pa.us > > pgman@candle.pha.pa.us | (610) 853-3000 > > + If your life is a hard drive, | 830 Blythe Avenue > > + Christ can be your backup. | Drexel Hill, Pennsylvania 19026 > > > > ---------------------------(end of broadcast)--------------------------- > > TIP 6: Have you searched our list archives? > > > > http://archives.postgresql.org > > > >
-
Re: Time for 7.2.1?
Bruce Momjian <pgman@candle.pha.pa.us> — 2002-03-19T12:11:36Z
D'Arcy J.M. Cain wrote: > On March 18, 2002 06:12 pm, Bruce Momjian wrote: > > OK, I have branded 7.2.1 and updated HISTORY/release.sgml. Do we want > > any special text about the sequence bug fix, or just mention in the > > announcement that all 7.2 people should upgrade? > > Does this mean that I can start putting fixes and upgrades into PyGreSQL? Sure, main CVS is open for 7.3. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
-
Re: Time for 7.2.1?
Bruce Momjian <pgman@candle.pha.pa.us> — 2002-03-19T12:12:37Z
Oleg Bartunov wrote: > Bruce, > > we have something to add. It's quite important for users of our tsearch module. > Too late ? For 7.2.1, I don't think it is too late but I don't think we can wait days. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
-
Re: Time for 7.2.1?
Marc Fournier <scrappy@hub.org> — 2002-03-19T13:10:40Z
On Tue, 19 Mar 2002, Bruce Momjian wrote: > Oleg Bartunov wrote: > > Bruce, > > > > we have something to add. It's quite important for users of our tsearch module. > > Too late ? > > For 7.2.1, I don't think it is too late but I don't think we can wait > days. I'll do a wrap on Friday, if Oleg wants to get his stuff in and tested?