Horton

Thread

  1. a regression

    Marcin Mańk <marcin.mank@gmail.com> — 2011-01-25T16:46:08Z

    Hello.
I did:
git clone git://git.postgresql.org/git/postgresql.git && cd postgresql
&& ./configure --prefix=/home/marcin/pg91 --enable-cassert
--enable-debug && make check

which gave me the attached regression.diffs

marcin@skpsms:~/postgresql$ gcc -v
Using built-in specs.
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Debian
4.3.2-1.1' --with-bugurl=file:///usr/share/doc/gcc-4.3/README.Bugs
--enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr
--enable-shared --with-system-zlib --libexecdir=/usr/lib
--without-included-gettext --enable-threads=posix --enable-nls
--with-gxx-include-dir=/usr/include/c++/4.3 --program-suffix=-4.3
--enable-clocale=gnu --enable-libstdcxx-debug --enable-objc-gc
--enable-mpfr --enable-cld --enable-checking=release
--build=x86_64-linux-gnu --host=x86_64-linux-gnu
--target=x86_64-linux-gnu
Thread model: posix
gcc version 4.3.2 (Debian 4.3.2-1.1)
marcin@skpsms:~/postgresql$ uname -a
Linux skpsms 2.6.24-23-xen #1 SMP Mon Jan 26 03:09:12 UTC 2009 x86_64 GNU/Linux

Greetings
Marcin Mańk

  2. Re: a regression

    Marcin Mańk <marcin.mank@gmail.com> — 2011-01-25T16:56:28Z

    On Tue, Jan 25, 2011 at 5:46 PM, marcin mank <marcin.mank@gmail.com> wrote:
> Hello.
> I did:
> git clone git://git.postgresql.org/git/postgresql.git && cd postgresql
> && ./configure --prefix=/home/marcin/pg91 --enable-cassert
> --enable-debug && make check
>
> which gave me the attached regression.diffs
>

uh, this may have something to do with :

marcin@skpsms:~/postgresql$ locale
LANG=pl_PL.UTF-8
LC_CTYPE="pl_PL.UTF-8"
LC_NUMERIC="pl_PL.UTF-8"
LC_TIME="pl_PL.UTF-8"
LC_COLLATE="pl_PL.UTF-8"
LC_MONETARY="pl_PL.UTF-8"
LC_MESSAGES="pl_PL.UTF-8"
LC_PAPER="pl_PL.UTF-8"
LC_NAME="pl_PL.UTF-8"
LC_ADDRESS="pl_PL.UTF-8"
LC_TELEPHONE="pl_PL.UTF-8"
LC_MEASUREMENT="pl_PL.UTF-8"
LC_IDENTIFICATION="pl_PL.UTF-8"

Because
LC_COLLATE=C make check

passes.

If this is expected, sorry for the noise.

Greetings
Marcin Mańk

  3. Re: a regression

    Tom Lane <tgl@sss.pgh.pa.us> — 2011-01-25T17:30:58Z

    marcin mank <marcin.mank@gmail.com> writes:
> On Tue, Jan 25, 2011 at 5:46 PM, marcin mank <marcin.mank@gmail.com> wrote:
>> I did:
>> git clone git://git.postgresql.org/git/postgresql.git && cd postgresql
>> && ./configure --prefix=/home/marcin/pg91 --enable-cassert
>> --enable-debug && make check
>> 
>> which gave me the attached regression.diffs

> uh, this may have something to do with :

> marcin@skpsms:~/postgresql$ locale
> LC_COLLATE="pl_PL.UTF-8"

It's only a regression if it used to pass in that locale.  We can't
realistically try to support every possible locale in the tests.

			regards, tom lane

  4. Re: a regression

    Andrew Dunstan <andrew@dunslane.net> — 2011-01-25T19:43:31Z

    
On 01/25/2011 12:30 PM, Tom Lane wrote:
>
>
>> marcin@skpsms:~/postgresql$ locale
>> LC_COLLATE="pl_PL.UTF-8"
> It's only a regression if it used to pass in that locale.  We can't
> realistically try to support every possible locale in the tests.
>
> 		

Maybe someone would like to set up a buildfarm member that tests a whole 
slew of locales. We've had the capability for a couple of years now.

cheers

andrew

  5. Re: a regression

    Peter Eisentraut <peter_e@gmx.net> — 2011-01-25T21:06:21Z

    On tis, 2011-01-25 at 12:30 -0500, Tom Lane wrote:
> marcin mank <marcin.mank@gmail.com> writes:
> > On Tue, Jan 25, 2011 at 5:46 PM, marcin mank <marcin.mank@gmail.com> wrote:
> >> I did:
> >> git clone git://git.postgresql.org/git/postgresql.git && cd postgresql
> >> && ./configure --prefix=/home/marcin/pg91 --enable-cassert
> >> --enable-debug && make check
> >> 
> >> which gave me the attached regression.diffs
> 
> > uh, this may have something to do with :
> 
> > marcin@skpsms:~/postgresql$ locale
> > LC_COLLATE="pl_PL.UTF-8"
> 
> It's only a regression if it used to pass in that locale.  We can't
> realistically try to support every possible locale in the tests.

I can say with some authority that we don't support the pl (glibc)
locale in the regression tests.

  6. Re: a regression

    David Fetter <david@fetter.org> — 2011-01-25T21:15:51Z

    On Tue, Jan 25, 2011 at 02:43:31PM -0500, Andrew Dunstan wrote:
> On 01/25/2011 12:30 PM, Tom Lane wrote:
> >>marcin@skpsms:~/postgresql$ locale
> >>LC_COLLATE="pl_PL.UTF-8"
> >It's only a regression if it used to pass in that locale.  We can't
> >realistically try to support every possible locale in the tests.
> 
> Maybe someone would like to set up a buildfarm member that tests a
> whole slew of locales. We've had the capability for a couple of
> years now.

Is it just a matter of setting a flock of environment variables as
part of the setup?

Cheers,
David.
-- 
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

  7. Re: a regression

    Tom Lane <tgl@sss.pgh.pa.us> — 2011-01-25T21:19:59Z

    Andrew Dunstan <andrew@dunslane.net> writes:
> On 01/25/2011 12:30 PM, Tom Lane wrote:
>> It's only a regression if it used to pass in that locale.  We can't
>> realistically try to support every possible locale in the tests.

> Maybe someone would like to set up a buildfarm member that tests a whole 
> slew of locales. We've had the capability for a couple of years now.

I don't want to promise that we will fix any random locale that anyone
sets up on a buildfarm member.

What would probably be reasonable to do is a one-time run over a lot of
locales, and then collate the results to see how many distinct outputs
we see and over what sets of locales.  Then we could make some reasoned
decisions about which cases are worth carrying variant expected files
for.

			regards, tom lane

  8. Re: a regression

    Peter Eisentraut <peter_e@gmx.net> — 2011-01-25T21:28:00Z

    On tis, 2011-01-25 at 16:19 -0500, Tom Lane wrote:
> What would probably be reasonable to do is a one-time run over a lot
> of locales, and then collate the results to see how many distinct
> outputs we see and over what sets of locales.  Then we could make some
> reasoned decisions about which cases are worth carrying variant
> expected files for.

We already did that and the current state is the result of that.

http://archives.postgresql.org/message-id/200901111254.03722.peter_e@gmx.net