Re: texteq/byteaeq: avoid detoast [REVIEW]

Peter Eisentraut <peter_e@gmx.net>

From: Peter Eisentraut <peter_e@gmx.net>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Magnus Hagander <magnus@hagander.net>, Itagaki Takahiro <itagaki.takahiro@gmail.com>, Andy Colson <andy@squeakycode.net>, Noah Misch <noah@leadboat.com>, pgsql-hackers@postgresql.org

Date: 2011-01-18T04:18:55Z

Lists: pgsql-hackers

On mån, 2011-01-17 at 15:33 -0500, Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > On mån, 2011-01-17 at 07:35 +0100, Magnus Hagander wrote:
> >> In fact, aren't there cases where the *length test* also fails?
> 
> > Currently, two text values are only equal of strcoll() considers them
> > equal and the bits are the same.  So this patch is safe in that regard.
> 
> > There is, however, some desire to loosen this.
> 
> That isn't ever going to happen, unless you'd like to give up hash joins
> and hash aggregation on text values.

Since citext exists and supports hashing, it's obviously possible
nevertheless.