Re: psql: Add \dL to show languages
Andreas Karlsson <andreas@proxel.se>
From: Andreas Karlsson <andreas@proxel.se>
To: Josh Kupershmidt <schmiddy@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Fernando Ike <fike@midstorm.org>
Date: 2011-01-18T18:35:44Z
Lists: pgsql-hackers
Hi Josh,
Nope, I do not have any better ideas than "DO Blocks?".
Everything looks good with the exception one bug now.
\dL foo
********* QUERY **********
SELECT l.lanname AS "Name",
pg_catalog.pg_get_userbyid(l.lanowner) as "Owner",
l.lanpltrusted AS "Trusted"
FROM pg_catalog.pg_language lWHERE l.lanname ~ '^(foo)$'
ORDER BY 1;
**************************
ERROR: syntax error at or near "l"
LINE 4: FROM pg_catalog.pg_language lWHERE l.lanname ~ '^(foo)$'
I believe the fix is to move \n from before the WHERE clause to after
the FROM, and from before ORDER BY to after WHERE.
Fix this bug and I believe this patch is ready for a committer.
PS. You added some trailing withspace after printACLColumn, A
recommendation if you want to avoid it is to either have a git commit
hook which checks for that and/or have colouring of git diffs so you can
see it marked in red. I use both. :)
Andreas