Re: [PATCH] Return command tag 'REPLACE X' for CREATE OR REPLACE statements.
Alvaro Herrera <alvherre@commandprompt.com>
From: Alvaro Herrera <alvherre@commandprompt.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: KaiGai Kohei <kaigai@ak.jp.nec.com>, Marti Raudsepp <marti@juffo.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2011-01-14T14:24:55Z
Lists: pgsql-hackers
Excerpts from Robert Haas's message of vie ene 14 08:40:07 -0300 2011: > Also, I don't really like the way this spreads knowledge of the > completionTag out all over the backend. I think it would be better to > follow the existing model used by the COPY and COMMIT commands, > whereby the return value indicates what happened and > standard_ProcessUtility() uses that to set the command tag. Yeah, that looks ugly. However it's already ugly elsewhere: for example see PerformPortalFetch. I am not sure if it should be this patch's responsability to clean that stuff up. (Maybe we should decree that at least this patch shouldn't make the situation worse.) -- Álvaro Herrera <alvherre@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support