Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>)

Peter Eisentraut <peter_e@gmx.net>

From: Peter Eisentraut <peter_e@gmx.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Craig Ringer <craig@postnewspapers.com.au>, Elliot Chance <elliotchance@gmail.com>, pgsql-hackers@postgreSQL.org
Date: 2010-12-27T15:54:16Z
Lists: pgsql-hackers
On sön, 2010-12-26 at 12:31 -0500, Tom Lane wrote:
> We did clean up C++ keyword uses in the header files in 9.0, but your
> report shows it's already gotten broken again.  I'm disinclined to fix
> it unless someone steps up to create an automated test that will get
> run reasonably often.  We had that discussion when the patch to rename
> keyword-named fields was proposed, and nothing got done, and the
> current state of affairs is the entirely predictable result.

src/tools/pginclude/cpluspluscheck

What's missing is to automate this, but it's unclear in what context,
and perhaps also to what extend this should be a hard requirement.