Horton

Re: bug in SignalSomeChildren

Alvaro Herrera <alvherre@commandprompt.com>

View thread
From: Alvaro Herrera <alvherre@commandprompt.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Fujii Masao <masao.fujii@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-12-17T16:07:40Z
Lists: pgsql-hackers 
Excerpts from Tom Lane's message of vie dic 17 12:27:30 -0300 2010:
> Robert Haas <robertmhaas@gmail.com> writes:
> > I think the attached might be a little tidier.  Thoughts?
> 
> I'm not really thrilled at the idea of calling
> IsPostmasterChildWalSender for every child whether or not it will have
> any impact on the decision.  That involves touching shared memory which
> can be rather expensive (see previous discussions about shared cache
> lines and so forth).

Is it possible to save the "is walsender" flag in the Backend struct?
That would make it possible to solve the problem very easily.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support