Horton

Re: Fdw batch insert error out when set batch_size > 65535

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-06-09T13:28:30Z
Lists: pgsql-hackers 
Tomas Vondra <tomas.vondra@enterprisedb.com> writes:
> Note that the problem here is [1] - we're creating a lot of slots 
> referencing the same tuple descriptor, which inflates the duration. 
> There's a fix in the other thread, which eliminates ~99% of the 
> overhead. I plan to push that fix soon (a day or two).

Oh, okay, as long as there's a plan to bring the time back down.

			regards, tom lane

Commits

  1. Remove expensive test of postgres_fdw batch inserts

  2. Adjust batch size in postgres_fdw to not use too many parameters

  3. Implement support for bulk inserts in postgres_fdw