Re: BUG #17828: postgres_fdw leaks file descriptors on error and aborts aborted transaction in lack of fds
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@gmail.com>,
Etsuro Fujita <etsuro.fujita@gmail.com>,
Alexander Lakhin <exclusion@gmail.com>,
pgsql-bugs@lists.postgresql.org
Date: 2024-02-09T02:08:46Z
Lists: pgsql-bugs
Andres Freund <andres@anarazel.de> writes: > I agree that we can't just delay cleanup till, potentially, much later , but I > don't think that means that we have to wait 30s for each connection, > one-by-one. While that behavior is theoretically possible, I've heard no field complaints about it actually happening. I don't think we should move heaven and earth to prevent it, barring some evidence of it being a real-world issue. ISTM we do need to do something about this AcquireExternalFD failure though, because that's just self-inflicted damage. (And I think it's likely new since we invented WaitEventSets, though perhaps I'm wrong about that.) regards, tom lane
Commits
-
Fix resource leak when a FDW's ForeignAsyncRequest function fails
- 555276f85940 14.11 landed
- 481d7d1c01c6 15.6 landed
- 501cfd07dac6 16.2 landed