Re: pg_execute_from_file review

Alvaro Herrera <alvherre@commandprompt.com>

From: Alvaro Herrera <alvherre@commandprompt.com>
To: Dimitri Fontaine <dimitri@2ndquadrant.fr>
Cc: Itagaki Takahiro <itagaki.takahiro@gmail.com>, Joshua Tolley <eggyknap@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2010-11-29T23:56:03Z
Lists: pgsql-hackers
Excerpts from Dimitri Fontaine's message of lun nov 29 17:03:06 -0300 2010:
> Itagaki Takahiro <itagaki.takahiro@gmail.com> writes:

> > * I hope pg_execute_from_file (and pg_read_file) had an option
> >   to specify an character encoding of the file. Especially, SJIS
> >   is still used widely, but it is not a valid server encoding.
> 
> So, what about client_encoding here, again?

I tried this in an earlier iteration of this patch, and it works fine
(albeit with a Latin1 file in an UTF8 encoded database, but presumably
this is no different from any other pair of client/server encodings;
recoding took place correctly during execution).

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support