Horton

Re: s/LABEL/VALUE/ for ENUMs

Joshua D. Drake <jd@commandprompt.com>

View thread
From: "Joshua D. Drake" <jd@commandprompt.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: "David E. Wheeler" <david@kineticode.com>, Josh Berkus <josh@agliodbs.com>, Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>, PostgreSQL-development Hackers <pgsql-hackers@postgresql.org>
Date: 2010-11-23T19:52:06Z
Lists: pgsql-hackers 
On Tue, 2010-11-23 at 14:48 -0500, Robert Haas wrote:
> On Tue, Nov 23, 2010 at 2:01 PM, David E. Wheeler <david@kineticode.com> wrote:
> > On Nov 22, 2010, at 6:03 PM, Josh Berkus wrote:
> >
> >> ... "original patch".  Sorry.  Let's not fiddle with the names.
> >
> > To be clear, as things stand now, the new command is:
> >
> >    ALTER TYPE name ADD VALUE new_enum_value [ { BEFORE | AFTER } existing_enum_value ]
> >
> > So while the term in the SQL statement is "VALUE," it's called a "label" in the documentation. I think that's confusing. Does anyone else?
> 
> Yes.  As between the two options, I favor changing the command.  And
> let's also paint it pink.

We discussed this at West remember? When asked to paint a wall black we
ask, "which shade?".

JD

-- 
PostgreSQL.org Major Contributor
Command Prompt, Inc: http://www.commandprompt.com/ - 509.416.6579
Consulting, Training, Support, Custom Development, Engineering
http://twitter.com/cmdpromptinc | http://identi.ca/commandprompt