Re: fix ancient typo in transformRelOptions()

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers@postgresql.org
Date: 2025-08-05T22:10:54Z
Lists: pgsql-hackers
=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
> On 2025-Aug-05, Nathan Bossart wrote:
>> I noticed that this function has a "namspace" parameter.  The attached
>> patch adds the missing 'e'.

> I have vague recollections of it being this way because of "namespace"
> being a C++ keyword.  (commit is 3a5b77371522, but I don't have energy
> to look for the discussion right now.)

Oh, duh -- if you try cpluspluscheck you'll find it's unhappy.
I didn't locate the discussion of "namspace" either, but I did
notice that de160e2c0 used "nameSpace" for the same purpose.
Maybe we should standardize on that?  It looks less like a typo
than "namspace", for sure.

			regards, tom lane



Commits

  1. Rename transformRelOptions()'s "namspace" parameter to "nameSpace".

  2. Make backend header files C++ safe