Re: Preventing abort() and exit() calls in libpq
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
Michael Paquier <michael@paquier.xyz>,
Jacob Champion <pchampion@vmware.com>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
Daniel Gustafsson <daniel@yesql.se>, info@cspug.cz
Date: 2021-07-03T22:44:20Z
Lists: pgsql-hackers
Noah Misch <noah@leadboat.com> writes: > On Sat, Jul 03, 2021 at 10:45:59AM -0400, Tom Lane wrote: >> What I'm now thinking about is restricting the test to only be run on >> platforms where use of foo.a libraries is deprecated, so that we can >> be pretty sure that we won't hit this situation. Even if we only >> run the test on Linux, that'd be plenty to catch any mistakes. > Hmm. Static libraries are the rarer case on both AIX and Linux, but I'm not > aware of a relevant deprecation on either platform. If it comes this to, I'd > be more inclined to control the Makefile rule with an environment variable > (e.g. ENFORCE_LIBC_CALL_RESTRICTIONS) instead of reacting to the platform. That'd require buildfarm owner intervention, as well as intervention by users. Which seems like exporting our problems onto them. I'd really rather not go that way if we can avoid it. regards, tom lane
Commits
-
Further restrict the scope of no-exit()-in-libpq test.
- 792259591c0f 15.0 landed
-
Improve build-time check that libpq doesn't call exit().
- 2f7bae2f924d 15.0 landed
-
Fix portability fallout from commit dc227eb82.
- e45b0dfa1f10 15.0 landed
-
Add a build-time check that libpq doesn't call exit() or abort().
- dc227eb82ea8 15.0 landed