Horton

Re: Violation of principle that plan trees are read-only

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-05-21T16:05:58Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. In ExecInitModifyTable, don't scribble on the source plan.

  2. Rely on executor utils to build targetlist for DML RETURNING.

Attachments

I wrote:
> Oh, scratch that: I'd gotten confused about which branch I was
> working in.  It does change the output as you say.

After poking at that for awhile, I decided we need a small tweak
in EXPLAIN itself to make the output consistent.  See attached.

I'm now leaning against back-patching, as there is a user-visible
behavior change in EXPLAIN, and I don't think there are really
any severe consequences to the mistaken assignments.

			regards, tom lane