Horton

Re: ISN patch that applies cleanly with git apply

Peter Eisentraut <peter_e@gmx.net>

View thread
From: Peter Eisentraut <peter_e@gmx.net>
To: Peter Geoghegan <peter.geoghegan86@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, PG Hackers <pgsql-hackers@postgresql.org>, Jan Otto <asche@me.com>
Date: 2010-10-20T13:02:56Z
Lists: pgsql-hackers 
On ons, 2010-10-20 at 11:12 +0100, Peter Geoghegan wrote:
> Can I take it that there is no need for a formal review, where I
> answer various questions per
> http://wiki.postgresql.org/wiki/Reviewing_a_Patch?

The short answer is no.  But note that there is no such thing as a
"formal" review.  The page you link to is only a guideline if you set
out to review something and don't know what to do.