Re: string function - "format" function proposal
Alvaro Herrera <alvherre@commandprompt.com>
From: Alvaro Herrera <alvherre@commandprompt.com>
To: Itagaki Takahiro <itagaki.takahiro@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Pavel Stehule <pavel.stehule@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2010-10-14T02:11:43Z
Lists: pgsql-hackers
Excerpts from Itagaki Takahiro's message of mié oct 13 23:03:16 -0300 2010: > On Thu, Oct 14, 2010 at 10:23 AM, Robert Haas <robertmhaas@gmail.com> wrote: > > On Wed, Sep 29, 2010 at 3:59 AM, Pavel Stehule <pavel.stehule@gmail.com> wrote: > >> [ updated patch, in response to a review from Itagaki Takahiro ] > > > > This patch appears to be waiting for a second round of review. > > Itagaki-san, are you planning to do that? > > I can, but I was waiting for other people's comments about the design: > - format() in core, that implements %s, %i, and %l. > - substitute() for $n format and sprintf() that partially implements > the same function in C in contrib/stringfunc. > > I don't like having three similar functions for the same purpose, > but Pavel said they are the best solutions. What will be our consensus? I don't have much love for moving the position stuff ($n) out of the main function either. I've been meaning to take a look at how hard it would be to integrate that into format() in core -- no luck :-( -- Álvaro Herrera <alvherre@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support