Re: security label support, revised
Peter Eisentraut <peter_e@gmx.net>
From: Peter Eisentraut <peter_e@gmx.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>, Shigeru HANADA <hanada@metrosystems.co.jp>, KaiGai Kohei <kaigai@kaigai.gr.jp>, KaiGai Kohei <kaigai@ak.jp.nec.com>, pgsql-hackers@postgresql.org
Date: 2010-09-28T14:56:20Z
Lists: pgsql-hackers
On tis, 2010-09-28 at 09:22 -0400, Robert Haas wrote: > > I think it should actually be run as part of the regular build. > Ever > > since I started using git and developing like 10 features at once, > and > > other people doing the same, the chances of (hidden) OID conflicts > is > > growing immensely. > > Injecting nonessential checks into the build process doesn't seem like > a good idea to me. Typing 'make' should just do the build. If you > want to check for breakage, well, that's what 'make check' is for. I don't feel strongly either way, but if we want to philosophize for a minute, all these -W option on the compiler command line are nonessential checks. ;-) I suppose 'make check' should test whether the code behaves correctly rather than checking whether the code was structured consistently to begin with.