Horton

Re: Use \if/\endif to remove non-libxml2 expected output in regression tests

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Daniel Gustafsson <daniel@yesql.se>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-14T23:33:54Z
Lists: pgsql-hackers 
Michael Paquier <michael@paquier.xyz> writes:
> On Sun, Jun 14, 2026 at 07:12:24PM -0400, Tom Lane wrote:
>> I think it's worth covering, say, one of those paths, but we don't
>> have to hit every one of the duplicate copies.  So what do you think
>> of putting the early-exit \if after the first test that produces
>> one of those failures?

> Positioning the \if after the three initial INSERT queries (\if query
> that counts the number of tuples inserted), like in the patch I have
> posted upthread, is able to hit NO_XML_SUPPORT() in xmlin().  That
> would be enough.  Would you agree with that?

Works for me.

			regards, tom lane

Commits

  1. Trim regression test expected output for xml

  2. Add an expected-file to match behavior of latest libxml2.