Re: Re-thing PG_MODULE_MAGIC

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <pgman@candle.pha.pa.us>
Cc: josh@agliodbs.com, pgsql-hackers@postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Date: 2006-06-16T03:39:46Z
Lists: pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Josh Berkus wrote:
>>> The <quote>magic block</> present in all PostgreSQL-supported libraries
>>> is checked to guarantee compatibility.  For this reason, non-PostgreSQL
>>> libraries cannot be loaded in this way.
>> 
>> you need "must be" before "present".  

> Uh, the point is not that they need a magic block (though they do), but
> rather that the magic block is always checked.

It's a grammar complaint, not a factual complaint.  Personally I'd
suggest wording it as "the magic block required in all ..."

			regards, tom lane