Re: lock_timeout GUC patch - Review

Alvaro Herrera <alvherre@commandprompt.com>

From: Alvaro Herrera <alvherre@commandprompt.com>
To: Boszormenyi Zoltan <zb@cybertec.at>
Cc: Marc Cousin <cousinmarc@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2010-07-30T23:06:30Z
Lists: pgsql-hackers
Excerpts from Boszormenyi Zoltan's message of jue jul 29 07:55:38 -0400 2010:
> Hi,
> 
> Marc Cousin írta:
> > Hi, I've been reviewing this patch for the last few days. Here it is :
> >   
> ...
> >   * Are there dangers?
> > As it is a guc, it could be set globally, is that a danger ?
> >   
> 
> I haven't added any new code covering supplemental (e.g. autovacuum)
> processes,
> the interactions are yet to be discovered. Setting it globally is not
> recommended.

FWIW there is some code in autovacuum and other auxiliary processes that
forcibly sets statement_timeout to 0.  I think this patch should do
likewise.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support