Horton
Menu

Re: Allow wal_keep_segments to keep all segments

Simon Riggs <simon@2ndquadrant.com>

View thread
From: Simon Riggs <simon@2ndQuadrant.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, Fujii Masao <masao.fujii@gmail.com>, Alvaro Herrera <alvherre@commandprompt.com>, Josh Berkus <josh@agliodbs.com>, pgsql-hackers@postgresql.org
Date: 2010-06-02T19:36:53Z
Lists: pgsql-hackers 
On Wed, 2010-06-02 at 15:20 -0400, Bruce Momjian wrote:

> The attached patch allows wal_keep_segments = -1 to keep all segements; 
> this is particularly useful for taking a base backup, where you need all
> the WAL files during startup of the standby.  I have documented this
> usage in the patch as well.
> 
> I am thinking of applying this after 9.0 beta2 if there is no objection.

It's not clear to me why "keep all files until server breaks" is a good
setting. Surely you would set this parameter to the size of your disk.
Why allow it to go higher?

-- 
 Simon Riggs           www.2ndQuadrant.com