Horton

Re: Use \if/\endif to remove non-libxml2 expected output in regression tests

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Daniel Gustafsson <daniel@yesql.se>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-14T23:12:24Z
Lists: pgsql-hackers 
Michael Paquier <michael@paquier.xyz> writes:
> I would also like to drop xml_1.out with the previous trick \if, but
> at the end if you feel that there is still value in keeping some
> coverage for the multiple NO_XML_SUPPORT() paths, that's fine by me.
> Removing half of the regression output update pain is still better
> than removing none of it.

I think it's worth covering, say, one of those paths, but we don't
have to hit every one of the duplicate copies.  So what do you think
of putting the early-exit \if after the first test that produces
one of those failures?

			regards, tom lane

Commits

  1. Trim regression test expected output for xml

  2. Add an expected-file to match behavior of latest libxml2.