Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per

Simon Riggs <simon@2ndquadrant.com>

From: Simon Riggs <simon@2ndQuadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@commandprompt.com>, Fujii Masao <masao.fujii@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-04-05T20:18:21Z
Lists: pgsql-hackers
On Mon, 2010-04-05 at 15:58 -0400, Tom Lane wrote:
> Simon Riggs <simon@2ndQuadrant.com> writes:
> >  					(errmsg("recovery command file \"%s\" specified neither primary_conninfo nor restore_command",
> > -							RECOVERY_COMMAND_FILE)));
> > +							RECOVERY_COMMAND_FILE),
> > +					 errdetail("The database server will regularly poll the pg_xlog subdirectory to check for files placed there.")));
> 
> That's not a "detail", as it has nothing to do with details of the error
> condition.  It might pass muster as a "hint", though I'm not entirely
> sure what the point is.

The server sits around doing nothing and the point of the message is to
explain why that is and give a hint as to what might change that
situation, if anything.

-- 
 Simon Riggs           www.2ndQuadrant.com