Horton

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-11-13T17:03:52Z
Lists: pgsql-hackers 
Masahiko Sawada <sawada.mshk@gmail.com> writes:
> [ pgbench_custom_initialization_v16.patch ]

I'm starting to review this patch, and I wonder how it is that you
ended up with "c" as the command letter for dropping existing tables.
Seems like "d" for DROP would be much less confusing.  I see that at
one point "d" meant the data load step, but since you've gone with
"g" for "generate data" that conflict is gone.

			regards, tom lane

Commits

  1. Allow running just selected steps of pgbench's initialization sequence.