Horton

Re: Parallel safety of binary_upgrade_create_empty_extension

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-03-30T21:26:21Z
Lists: pgsql-hackers 
I wrote:
> Anyway, that looks like 11 functions that there's no question we
> need to relabel.  I'll go do that.

Oh, while I'm looking at this, I notice that cursor_to_xml[schema]
is not merely mismarked as to its parallel safety, but its volatility:
it's marked stable, which is frickin' insane considering it has side
effects on the state of the cursor.

query_to_xml* are likewise marked stable, which seems also foolish
since we have no idea whether the source query has side-effects.

All of this breakage is pretty old.  I guess the best we can do is
fix it without a catversion bump in the back branches.

			regards, tom lane

Commits

  1. Fix bogus provolatile/proparallel markings on a few built-in functions.