Horton
Menu

Re: pg_stop_backup does not complete

Simon Riggs <simon@2ndquadrant.com>

View thread
From: Simon Riggs <simon@2ndQuadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Josh Berkus <josh@agliodbs.com>, Greg Smith <greg@2ndQuadrant.com>, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-02-25T00:41:27Z
Lists: pgsql-hackers 
On Wed, 2010-02-24 at 19:08 -0500, Tom Lane wrote:
> Simon Riggs <simon@2ndQuadrant.com> writes:
> > On Wed, 2010-02-24 at 16:52 -0500, Tom Lane wrote:
> >> * emit a NOTICE as soon as pg_stop_backup's actual work is done and
> >> it's starting to wait for the archiver (or maybe after it's waited
> >> for a few seconds, but much less than the present 60).
> 
> > Pointless really. Nobody runs backups in production by typing
> > pg_stop_backup() except in a demo. Nobody will see this. 
> 
> I agree it's pointless in production, but this isn't about production,
> it's about friendliness to people who are experimenting.  The case will
> probably never come up in production because a production installation
> should have a non-broken archive_command.

No further objection.

-- 
 Simon Riggs           www.2ndQuadrant.com