Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
Robert Haas <robertmhaas@gmail.com>,
Dilip Kumar <dilipbalaut@gmail.com>,
Andres Freund <andres@anarazel.de>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-06-09T03:32:21Z
Lists: pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes: > On Tue, Jun 08, 2021 at 10:39:24AM -0400, Alvaro Herrera wrote: >> Maybe at this point reverting is the only solution. > That's a safe bet at this point. It would be good to conclude this > one by beta2 IMO. I still think it's a really dubious argument that anybody would want to incur a VACUUM FULL to force conversion to a different compression method. I can imagine sometime in the future where we need to get rid of all instances of pglz so we can reassign that compression code to something else. But would we insist on a mass VACUUM FULL to make that happen? Doubt it. You'd want a tool that would make that happen over time, in the background; like the mechanisms that have been discussed for enabling checksums on-the-fly. In the meantime I'm +1 for dropping this logic from VACUUM FULL. I don't even want to spend enough more time on it to confirm the different overhead measurements that have been reported. regards, tom lane
Commits
-
Remove forced toast recompression in VACUUM FULL/CLUSTER
- dbab0c07e5ba 14.0 landed
-
Rethink definition of pg_attribute.attcompression.
- e6241d8e030f 14.0 landed
-
Fix memory leak when de-toasting compressed values in VACUUM FULL/CLUSTER
- fb0f5f0172ed 14.0 landed
-
Re-order pg_attribute columns to eliminate some padding space.
- f5024d8d7b04 14.0 landed
-
Add more TAP tests for pg_dump with attribute compression
- 63db0ac3f9e6 14.0 cited