Re: An example of bugs for Hot Standby
Simon Riggs <simon@2ndquadrant.com>
From: Simon Riggs <simon@2ndQuadrant.com>
To: Hiroyuki Yamada <yamada@kokolink.net>
Cc: pgsql-hackers@postgresql.org
Date: 2010-01-21T09:11:27Z
Lists: pgsql-hackers
On Thu, 2010-01-21 at 18:01 +0900, Hiroyuki Yamada wrote: > I think the patch has two problems. > > * disable_standby_sig_alarm() does not clear standby_timeout_active flag > when it succeeds in disabling the alarm. Ah, thanks. > * Assertion check in HoldingBufferPinThatDelaysRecovery() can fail > with following scenario. Agreed. Will remove Assert() because of race conditions. Thanks, -- Simon Riggs www.2ndQuadrant.com