Re: Streaming replication, and walsender during recovery
Simon Riggs <simon@2ndquadrant.com>
From: Simon Riggs <simon@2ndQuadrant.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-01-19T07:41:10Z
Lists: pgsql-hackers
On Tue, 2010-01-19 at 15:04 +0900, Fujii Masao wrote: > > > > There is an ERROR, but no problem AFAICS. The tli isn't set until end of > > recovery because it doesn't need to have been set yet. That shouldn't > > prevent retrieving WAL data. > > OK. Here is the patch which supports a walsender process during recovery; > > * Change walsender so as to send the WAL written by the walreceiver > if it has been started during recovery. > * Kill the walsenders started during recovery at the end of recovery > because replication cannot survive the change of timeline ID. Good patch. I think we need to add a longer comment explaining the tli issues. I agree with your handling of them. It would be useful to have the ps display differentiate between multiple walsenders, and in this case have it indicate cascading also. -- Simon Riggs www.2ndQuadrant.com