Re: Hot Standby and query cancel

Simon Riggs <simon@2ndquadrant.com>

From: Simon Riggs <simon@2ndQuadrant.com>

To: Andres Freund <andres@anarazel.de>

Cc: pgsql-hackers@postgresql.org, Joachim Wieland <joe@mcknight.de>, Tom Lane <tgl@sss.pgh.pa.us>, Fujii Masao <masao.fujii@gmail.com>

Date: 2010-01-13T19:20:29Z

Lists: pgsql-hackers

Attachments

hs_cancel.2010_Jan_13.v2.patch (text/x-patch) patch v2

On Wed, 2010-01-13 at 19:58 +0100, Andres Freund wrote:

> > I am still testing patch, so should be confident to commit tomorrow
> > barring issues.
> I have only looked at briefly because right now I dont have the time (going to 
> eat at a friends place...) but I think I spotted an issue:
> The IsAbortedTransactionBlockState() check in RecoveryConflictInterrupt is not 
> correct right now because that returns true for TBLOCK_SUBABORT as well.
> Wouldnt that mess with the case where were in a failed subxact and then 
> rollback only that subxact?

Well spotted, yes. 

-- 
 Simon Riggs           www.2ndQuadrant.com