Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2020-11-20T02:48:52Z
Lists: pgsql-hackers
I wrote: > However ... it then occurred to me to blow away my ccache and accache, > and after rebuilding from scratch, everything's fine. So, are you > using ccache? Oh, scratch that, I fat-fingered the experiment somehow. The issue is still there. Still, I'm hesitant to apply the fix you suggest, because of the law of unintended consequences. In particular, I'm afraid that using -isysroot in the link step might result in executables that are bound to that sysroot and will not work if it's not there --- thus causing a problem for packagers trying to distribute PG to non-developers. We had a great deal of trouble in the initial experiments with -isysroot, cf https://www.postgresql.org/message-id/flat/20840.1537850987%40sss.pgh.pa.us so I'm not that eager to mess with it. I'm inclined to think that this is more a case of "Apple broke ABI and they ought to fix that". regards, tom lane
Commits
-
On macOS, use -isysroot in link steps as well as compile steps.
- e7abc1111634 9.6.21 landed
- d01e37845c22 11.11 landed
- 9e9a31bd0096 13.2 landed
- 5b83604270a6 12.6 landed
- 2bb8c0f1d94d 9.5.25 landed
- 153bf8d2044a 10.16 landed
- 49407dc32a29 14.0 landed